Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Oct 2019 21:11:53 +0100
From:      Niclas Zeising <zeising@freebsd.org>
To:        Jan Beich <jbeich@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r516100 - in head: graphics/libosmesa graphics/libxatracker graphics/mesa-dri graphics/mesa-dri/files graphics/mesa-libs lang/clover
Message-ID:  <c769c411-5f56-607b-dd1c-6046b9398e46@freebsd.org>
In-Reply-To: <1ruu-5845-wny@FreeBSD.org>
References:  <201910301907.x9UJ7W2N025166@repo.freebsd.org> <1ruu-5845-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-10-30 20:46, Jan Beich wrote:
> Niclas Zeising <zeising@FreeBSD.org> writes:
> 
>> Modified:
>>    head/graphics/libosmesa/Makefile
>>    head/graphics/libxatracker/Makefile
>>    head/graphics/mesa-dri/Makefile
>>    head/graphics/mesa-dri/files/patch-configure
> 
> Did you forget to sync with files/configure.ac? In the past[1] the file
> was used whenever mesa-dri or related ports had to add USES=autoreconf.
> 
> [1] before https://svnweb.freebsd.org/changeset/ports/472508
> 

Currently, there is no patch for configure.ac, but several for 
configure, and as far as I can tell, no mesa port is using autoreconf. 
Adding a patch for configure.ac that's not used by any port feels 
unnecessary, especially since only patching for this issue would make it 
incomplete.  Having a file in files/ that's not actually used is just a 
recipe for it getting stale.
Regards
-- 
Niclas Zeising



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c769c411-5f56-607b-dd1c-6046b9398e46>