From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Oct 13 16:20:18 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 46B3316A41F for ; Thu, 13 Oct 2005 16:20:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD8FD43D48 for ; Thu, 13 Oct 2005 16:20:17 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9DGKHX3016320 for ; Thu, 13 Oct 2005 16:20:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j9DGKH3c016319; Thu, 13 Oct 2005 16:20:17 GMT (envelope-from gnats) Resent-Date: Thu, 13 Oct 2005 16:20:17 GMT Resent-Message-Id: <200510131620.j9DGKH3c016319@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Zahemszky Gabor Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 187A816A41F for ; Thu, 13 Oct 2005 16:17:40 +0000 (GMT) (envelope-from zgabor@zahemszky.hu) Received: from zahemszky.hu (dsl51B6CCFA.pool.t-online.hu [81.182.204.250]) by mx1.FreeBSD.org (Postfix) with ESMTP id 60DE243D4C for ; Thu, 13 Oct 2005 16:17:38 +0000 (GMT) (envelope-from zgabor@zahemszky.hu) Received: from zahemszky.hu (localhost [127.0.0.1]) by Picasso.Zahemszky.HU (8.13.4/8.13.1) with ESMTP id j9DGIxIC000785 for ; Thu, 13 Oct 2005 18:18:59 +0200 (CEST) (envelope-from zgabor@zahemszky.hu) Received: (from zgabor@localhost) by zahemszky.hu (8.13.4/8.13.1/Submit) id j9DGIwpA000784; Thu, 13 Oct 2005 18:18:58 +0200 (CEST) (envelope-from zgabor) Message-Id: <200510131618.j9DGIwpA000784@zahemszky.hu> Date: Thu, 13 Oct 2005 18:18:58 +0200 (CEST) From: Zahemszky Gabor To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/87374: incorrect use of WITH_THEORA vs. WITH_LIBTHEORA in some ports X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Zahemszky Gabor List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2005 16:20:18 -0000 >Number: 87374 >Category: ports >Synopsis: incorrect use of WITH_THEORA vs. WITH_LIBTHEORA in some ports >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Oct 13 16:20:17 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Zahemszky Gabor >Release: FreeBSD 5.4-STABLE i386 >Organization: >Environment: System: FreeBSD zahemszky.hu 5.4-STABLE FreeBSD 5.4-STABLE #0: Wed Sep 28 20:30:48 CEST 2005 root@Picasso.Zahemszky.HU:/usr/obj/usr/src/sys/PICASSO i386 >Description: Many ports in the audio and multimedia categories (and maybe others) have optional dependencies to special libraries (eg. libogg, libvorbis). It looks like in the FreeBSD ports-tree, there isn't a correct way to tell the libtheora dependency. Eg, in multimedia, there are libxine, vlc and vlc-devel, which use the WITH_LIBTHEORA (or WITHOUT_LIBTHEORA) Makefile variable, but ffmpeg-devel, mplayer and transcode use the WITH_THEORA (ot WITHOUT_THEORA) variables. So if somebody'd like to include (exclude) libtheora, she has to define two variables in /etc/make.conf: WITH_THEORA and WITH_LIBTHEORA (or w/o). It would be better to use one; and after the other similar variable's name, I think WITH_THEORA is the correct name. >How-To-Repeat: egrep -R 'WITH(OUT)?_(LIB)?THEORA' /usr/ports >Fix: In /usr/ports/multimedia/{libxine,vlc,vlc-devel}/Makefile, in the next (or similar lines), change the WITH(OUT)?_LIBTHEORA strings to WITH(OUT)?_THEORA. == if !defined(WITHOUT_LIBTHEORA) && (exists(${LOCALBASE}/lib/libtheora.so.1) || defined (WITH_LIBTHEORA)) == >Release-Note: >Audit-Trail: >Unformatted: