From owner-cvs-all Sun Jan 26 14:17:10 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3F59337B401; Sun, 26 Jan 2003 14:17:09 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57EAA43E4A; Sun, 26 Jan 2003 14:17:08 -0800 (PST) (envelope-from phk@freebsd.org) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id h0QMH6Ql011295; Sun, 26 Jan 2003 23:17:07 +0100 (CET) (envelope-from phk@freebsd.org) To: Garrett Wollman Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/disklabel disklabel.c From: phk@freebsd.org In-Reply-To: Your message of "Sun, 26 Jan 2003 17:14:41 EST." <200301262214.h0QMEfiV078221@khavrinen.lcs.mit.edu> Date: Sun, 26 Jan 2003 23:17:06 +0100 Message-ID: <11294.1043619426@critter.freebsd.dk> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200301262214.h0QMEfiV078221@khavrinen.lcs.mit.edu>, Garrett Wollman writes: >< said: > >> If we fail to open O_RDWR, try opening O_RDONLY, if we use ioctls >> to fiddle the disk we can get away with it. > >Uh, if the ioctls actually succeed in fiddling the disk, that's a >serious security problem. I don't think so in practice, but if we want to put an suser() check there to be pure it's ok with me. critter phk> ls -l /dev/ad0 crw-r----- 1 root operator 4, 1 Jan 25 23:13 /dev/ad0 -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message