From owner-svn-src-head@freebsd.org Sun Jul 29 20:37:12 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DEC8E106299C for ; Sun, 29 Jul 2018 20:37:11 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic301-22.consmr.mail.gq1.yahoo.com (sonic301-22.consmr.mail.gq1.yahoo.com [98.137.64.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6A802786CB for ; Sun, 29 Jul 2018 20:37:11 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: pDfYAfAVM1mY0nTtCTaJKTgl.3kAaf1ONa978xWSEnzL25jnxbChjVYnYrmEqi_ lOYt8Fq2Ng_VpmteodcMwxw_o6.hzRJfpSHTaZi5qFUQVjyXwq4dxrSckrJAsx8MywIwT4e4BrBh IAZmGhzs4y2eVf3X1G2EEm7K37wFt1I7fB4ilhq4bCjyAFYj3x4ObdA2pkw85E_e6pnnWc.eXlo3 fszKnoeTn00pA6Gf6D3hc7AMcAvxUSK3m1i72UrKa5iTigqbkA942qfA5bQKAnZ15_Vgie.E5LPJ ng0jrO_Sdrxo578KNcF.eIl8_RKEqkCpYzosv3qJxYOYbKC1jotafRF.NcGDo3D0TeQUx5c5CdJH rbveFT_XiCqNHG19M.5EYKEHXkCn_AogJDxCVv.9CZB4EpqZELqTPTZ0qaE8Nulou3AATle.CC3. w5sQTpSgGn2QoM9hVVv6Oqn_fzQwtvZxVN8fBJbw.KO0NLNNsDOvbhYV0MYABvLkIVJgVpeMZslC vhh0h1r6wReoI2XTjQao2w5kYZkD19tR_644rSQkG2Get8MJc34o8WcKZLCcFREJS7hK.rKO00CG 7Dhlt0MtkvjAW4vFmvU0JA71.AgucQ1dzOL95COV9_rH3LWqPuuQTqjScrdA8isTS5JEIy6oV_QT c.LdbFyufpW3A.FBSY5zU5VzV94gs3fsCP87nsTioh3f5PrZx35Qfd1TyTv03xao5FdHwhvORtJ5 t6o.Ahsa_WcLWRudP.xTR.Gl1DtRqRNYYT_BCwMZ5ZyeSm_Zp212jpWcfKvRSmn1vNQ.a1GAJ_Fn 65pWkB4ZZvyam0i4qtHaRiNapQkgXjbdNSHNKrwTizYjwWc5qHDuNmlRn6JXdeV7kIifv3lRAjUP j5YKnFnI5Hk2m7eQIY0KRPF9LzoT1sUv4o_eSQpZSRg6O.9KeMfPZA9qttl2KvW9wnZbPgjov1.j 1CVVS6k999nscnLC4uwtMSz0c7KecbOl4kcUW6Hq9b_eSQP3Ll14L43hoBDsiFRYSbN1YOKYPYQ1 0tJA- Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Sun, 29 Jul 2018 20:37:02 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp411.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 8ca879964c867f1a70e8902453182fff; Sun, 29 Jul 2018 20:36:59 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: svn commit: r336744 - in head: sbin/pfctl/tests/files share/mk From: Mark Millard In-Reply-To: <1532836798.1025520.1456191920.7D934477@webmail.messagingengine.com> Date: Sun, 29 Jul 2018 13:36:58 -0700 Cc: svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <1532836798.1025520.1456191920.7D934477@webmail.messagingengine.com> To: Brad Davis X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jul 2018 20:37:12 -0000 On 2018-Jul-28, at 8:59 PM, Brad Davis wrote: > On Sat, Jul 28, 2018, at 9:53 PM, Mark Millard wrote: >> Brad Davis brd at FreeBSD.org wrote on >> Thu Jul 26 17:11:15 UTC 2018 : >>=20 >>> On Thu, Jul 26, 2018, at 11:09 AM, Shawn Webb wrote: >>> . . . >>>>> -FILES=3D ${.CURDIR}/pf????.in >>>>> -FILES+=3D ${.CURDIR}/pf????.include >>>>> -FILES+=3D ${.CURDIR}/pf????.ok >>>>> +FILES!=3D echo ${.CURDIR}/pf????.in = ${.CURDIR}/pf????.include ${.CURDIR}/pf????.ok >>>>=20 >>>> Should this use ${ECHO} instead of echo? >>>=20 >>>=20 >>> No, that wouldn't work at all with the !=3D. >>=20 >> /usr/ports/Mk/bsd.port.mk has things like: >>=20 >> OPSYS!=3D ${UNAME} -s >> and: >> _OSRELEASE!=3D ${UNAME} -r >>=20 >> Is your ${ECHO} note specific to the combination of ${ECHO} and !=3D >> for some reason --or does it apply to the likes of ${UNAME} mixed >> with !=3D too? >=20 > That is different.. due to share/mk/sys.mk has: >=20 > .if empty(.MAKEFLAGS:M-s) > ECHO ?=3D echo > ECHODIR ?=3D echo > .else > ECHO ?=3D true > .if ${.MAKEFLAGS:M-s} =3D=3D "-s" > ECHODIR ?=3D echo > .else > ECHODIR ?=3D true > .endif > .endif >=20 > Which means if someone is using make -s, these tests would not = install.. which is probably not what is desired and there are better = ways to do that. Thanks. Looking around I see that /usr/ports/Mk/bsd.commands.mk has: # ECHO is defined in /usr/share/mk/sys.mk, which can either be "echo", # or "true" if the make flag -s is given. Use ECHO_CMD where you mean # the echo command. ECHO_CMD?=3D echo # Shell builtin # Used to print all the '=3D=3D=3D>' style prompts - override this to = turn them off. ECHO_MSG?=3D ${ECHO_CMD} So may be ${ECHO_CMD} would be an alternate to echo. =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)