From owner-freebsd-current Mon Jan 12 17:57:54 1998 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id RAA08325 for current-outgoing; Mon, 12 Jan 1998 17:57:54 -0800 (PST) (envelope-from owner-freebsd-current) Received: from smtp04.primenet.com (smtp04.primenet.com [206.165.6.134]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id RAA08317 for ; Mon, 12 Jan 1998 17:57:36 -0800 (PST) (envelope-from tlambert@usr01.primenet.com) Received: (from daemon@localhost) by smtp04.primenet.com (8.8.8/8.8.8) id SAA16066; Mon, 12 Jan 1998 18:56:48 -0700 (MST) Received: from usr01.primenet.com(206.165.6.201) via SMTP by smtp04.primenet.com, id smtpd016012; Mon Jan 12 18:56:42 1998 Received: (from tlambert@localhost) by usr01.primenet.com (8.8.5/8.8.5) id SAA14174; Mon, 12 Jan 1998 18:56:36 -0700 (MST) From: Terry Lambert Message-Id: <199801130156.SAA14174@usr01.primenet.com> Subject: Re: Firewall in kernel? - Found it! To: nash@mcs.net (Alex Nash) Date: Tue, 13 Jan 1998 01:56:36 +0000 (GMT) Cc: shimon@simon-shapiro.org, nash@mcs.net, kong@kkk.ml.org, Studded@dal.net, current@FreeBSD.ORG, thyerm@camtech.net.au In-Reply-To: <199801110242.UAA10815@nash.pr.mcs.net> from "Alex Nash" at Jan 10, 98 08:42:48 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Sender: owner-freebsd-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > While these steps are highly recommendable (I try to check commits > against up-to-the-minute sources in a similar way), they can't prevent > problems such as the one involved in this thread (i.e. the exit codes > for ipfw causing breakage for the non-firewall kernels). No. That particular problem resulted from checking for the nonexistance of a specific error condition to signal success, instead of looking for the (single) specific success condition. In other words, it was just a bad test. Probably the best place to address that would be a "style" for the files involved (comments at the top, maybe?). Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.