Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 Oct 2019 12:50:11 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Tobias Kortkamp <tobik@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r515252 - head/x11/cool-retro-term
Message-ID:  <20191023125011.GA89792@FreeBSD.org>
In-Reply-To: <20191023124302.GA64150@urd.tobik.me>
References:  <201910231211.x9NCBOf2070687@repo.freebsd.org> <20191023124302.GA64150@urd.tobik.me>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 23, 2019 at 02:43:02PM +0200, Tobias Kortkamp wrote:
> On Wed, Oct 23, 2019 at 12:11:24PM +0000, Alexey Dokuchaev wrote:
> > New Revision: 515252
> > URL: https://svnweb.freebsd.org/changeset/ports/515252
> > 
> > Log:
> >   - Switch to USES+=compiler:c++11-lang to unbreak on PowerPC instead
> >     of the approach taken in r513793 (Clang was never required for this
> >     port, any not-so-ancient compiler would suffice)
> >   - Sort the values on the USES list; avoid hardcoding version numbers
> > [...]
> > @@ -16,24 +16,15 @@ GH_ACCOUNT=	Swordfish90
> >  GH_PROJECT=	qmltermwidget:qtw
> >  GH_TAGNAME=	0.2.0:qtw
> > [...]
> >  post-extract:
> >  	@${RMDIR} ${WRKSRC}/qmltermwidget
> > -	@${LN} -s ../qmltermwidget-0.2.0 ${WRKSRC}/qmltermwidget
> > +	@${LN} -s ../qmltermwidget-${GH_TAGNAME_qtw} ${WRKSRC}/qmltermwidget
> 
> This is very complicated

Not true. :)

> and unnecessary.

That's true.

> post-extract should be removed and replaced with
> GH_SUBDIR=	qmltermwidget:qtw

Yeah, I know; AFAIR I've ported this before we had multi-repo (external
references) support in the framework and never converted.  I can do that
if you insist.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191023125011.GA89792>