Date: Sun, 27 Apr 2014 08:13:09 -0700 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: Luiz Otavio O Souza <loos@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r265012 - in head/sys/dev: gpio ofw Message-ID: <535D1E85.8020502@freebsd.org> In-Reply-To: <201404271211.s3RCB1wI018791@svn.freebsd.org> References: <201404271211.s3RCB1wI018791@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/27/14 05:11, Luiz Otavio O Souza wrote: > Author: loos > Date: Sun Apr 27 12:11:00 2014 > New Revision: 265012 > URL: http://svnweb.freebsd.org/changeset/base/265012 > > Log: > Fix the gpio-specifier decoding by respecting the GPIO controller's > #gpio-cells property. > > Add a new ofw_bus method (OFW_BUS_MAP_GPIOS()) that allows the GPIO > controller to implement its own mapping to deal with gpio-specifiers, > allowing the decoding of gpio-specifiers to be controller specific. > > The default ofw_bus_map_gpios() decodes the linux standard (#gpio-cells = > <2>) and the FreeBSD standard (#gpio-cells = <3>). > > It pass the gpio-specifier flag field to the children as an ivar variable so > they can act upon. > > Modified: > head/sys/dev/gpio/gpiobusvar.h > head/sys/dev/gpio/ofw_gpiobus.c > head/sys/dev/ofw/ofw_bus.h > head/sys/dev/ofw/ofw_bus_if.m Would it be possible to put the routines from ofw_bus* into dev/gpio instead? I'd like to avoid polluting dev/ofw with bus-specific parts as much as possible. -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?535D1E85.8020502>