From owner-svn-src-all@FreeBSD.ORG Thu Feb 16 08:56:14 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93CAC1065674; Thu, 16 Feb 2012 08:56:14 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail08.syd.optusnet.com.au (mail08.syd.optusnet.com.au [211.29.132.189]) by mx1.freebsd.org (Postfix) with ESMTP id 0F2458FC13; Thu, 16 Feb 2012 08:56:13 +0000 (UTC) Received: from c211-30-171-136.carlnfd1.nsw.optusnet.com.au (c211-30-171-136.carlnfd1.nsw.optusnet.com.au [211.30.171.136]) by mail08.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q1G8u9O7029463 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 16 Feb 2012 19:56:11 +1100 Date: Thu, 16 Feb 2012 19:56:09 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Hiroki Sato In-Reply-To: <20120216.164332.2209961872967607025.hrs@allbsd.org> Message-ID: <20120216194921.X1656@besplex.bde.org> References: <201202160517.q1G5H6Z0000155@svn.freebsd.org> <20120216.164332.2209961872967607025.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, eadler@FreeBSD.org Subject: Re: svn commit: r231817 - head/usr.sbin/IPXrouted X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2012 08:56:14 -0000 On Thu, 16 Feb 2012, Hiroki Sato wrote: > Eitan Adler wrote > in <201202160517.q1G5H6Z0000155@svn.freebsd.org>: > > ea> Author: eadler > ea> Date: Thu Feb 16 05:17:06 2012 > ea> New Revision: 231817 > ea> URL: http://svn.freebsd.org/changeset/base/231817 > ea> > ea> Log: > ea> Fix warning when compiling with gcc46 > IMHO it is not a good idea to remove unused code partially like this > or unused code in one from another project if you just want to > suppress a compiler warning. It may suppress the warning, but > remaining bits in comments and/or conditional parts where the > compiler does not complain make developers confused. I think it is > more harmful than the warning. This is another example of the phenomenon that small bikesheds are the hardest to paint :-). It is surprisingly difficult to make many small harmless-looking changes correctly without knowing their full context, since just determining their full context may take a day or three. Each. Bruce