Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Mar 2016 00:36:45 +0000 (UTC)
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r296591 - head/sys/dev/firewire
Message-ID:  <201603100036.u2A0ajnK028347@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: imp
Date: Thu Mar 10 00:36:45 2016
New Revision: 296591
URL: https://svnweb.freebsd.org/changeset/base/296591

Log:
  Don't assume bio_cmd is a bit field.
  
  Differential Revision: https://reviews.freebsd.org/D5594

Modified:
  head/sys/dev/firewire/fwmem.c

Modified: head/sys/dev/firewire/fwmem.c
==============================================================================
--- head/sys/dev/firewire/fwmem.c	Thu Mar 10 00:36:38 2016	(r296590)
+++ head/sys/dev/firewire/fwmem.c	Thu Mar 10 00:36:45 2016	(r296591)
@@ -364,7 +364,7 @@ fwmem_strategy(struct bio *bp)
 	}
 
 	iolen = MIN(bp->bio_bcount, MAXLEN);
-	if ((bp->bio_cmd & BIO_READ) == BIO_READ) {
+	if (bp->bio_cmd == BIO_READ) {
 		if (iolen == 4 && (bp->bio_offset & 3) == 0)
 			xfer = fwmem_read_quad(fwdev,
 			    (void *)bp, fwmem_speed,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201603100036.u2A0ajnK028347>