Date: Mon, 2 Feb 2009 13:44:16 +0900 From: Pyun YongHyeon <pyunyh@gmail.com> To: "M. Warner Losh" <imp@bsdimp.com> Cc: src-committers@freebsd.org, thompsa@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r187978 - user/thompsa/usb/sys/dev/usb2/ethernet Message-ID: <20090202044416.GC43513@michelle.cdnetworks.co.kr> In-Reply-To: <20090201.203618.1640016624.imp@bsdimp.com> References: <200902010650.n116obU1045871@svn.freebsd.org> <20090201.142808.886478999.imp@bsdimp.com> <20090201213749.GJ32503@citylink.fud.org.nz> <20090201.203618.1640016624.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 01, 2009 at 08:36:18PM -0700, M. Warner Losh wrote: > In message: <20090201213749.GJ32503@citylink.fud.org.nz> > Andrew Thompson <thompsa@FreeBSD.org> writes: > : On Sun, Feb 01, 2009 at 02:28:08PM -0700, M. Warner Losh wrote: > : > In message: <200902010650.n116obU1045871@svn.freebsd.org> > : > Andrew Thompson <thompsa@FreeBSD.org> writes: > : > : + locked = mtx_owned(&sc->sc_mtx); > : > : + if (!locked) > : > : + AUE_LOCK(sc); > : > > : > You do know this is racy, right? > : > : Yea... It only get called unlocked during mii probe+attach so its fine. > : I havnt actaully checked if its ok to hold a mutex during > : mii_phy_probe() which would make this go away. > > You hold GIANT when probe+attach, which means I think you can't AFAIK this is not true on USB2 and I think this is reason why it have to lock/unlock dance in probe/attach. > acquire any other locks... > > Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090202044416.GC43513>