Date: Sat, 03 Apr 2010 15:09:34 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Ion-Mihai Tetcu <itetcu@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Sahil Tandon <sahil@tandon.net>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/postpals pkg-plist ports/mail/postpals/files postpals-taillog.in postpals.in Message-ID: <4BB7BC9E.2060706@FreeBSD.org> In-Reply-To: <201004031443.o33Eh5N6062631@repoman.freebsd.org> References: <201004031443.o33Eh5N6062631@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/03/10 07:43, Ion-Mihai Tetcu wrote: > itetcu 2010-04-03 14:43:05 UTC > > FreeBSD ports repository > > Modified files: > mail/postpals pkg-plist > mail/postpals/files postpals-taillog.in postpals.in > Log: > - fix plist (deinstall) > - fix rc script > > Submitted by: Sahil Tandon (maintainer) > > Revision Changes Path > 1.2 +2 -2 ports/mail/postpals/files/postpals-taillog.in > 1.2 +2 -2 ports/mail/postpals/files/postpals.in > 1.3 +1 -0 ports/mail/postpals/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/postpals/files/postpals-taillog.in.diff?&r1=1.1&r2=1.2&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/postpals/files/postpals.in.diff?&r1=1.1&r2=1.2&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/postpals/pkg-plist.diff?&r1=1.2&r2=1.3&f=h The command_interpreter change is a good one, but it should probably be changed to %%PERL%% since that should work whether or not the link is installed in /usr/bin. Couple other problems, the scripts used %%RC_SUBR%% which is going away, hopefully soon if portmgr actually commits my patch. :) I've already fixed that one. The other problem is with this: case "$postpals_enable" in [Yy][Ee][Ss] | 1 | [Oo][Nn] | [Tt][Rr][Uu][Ee]) ;; *) echo "To make use of $name you must first set $rcvar=\"YES\" in /etc/rc.conf" ;; esac Two problems there, first if you're going to test a boolean in rc.d it should always be done with checkyesno to be on the safe side. But more importantly, the user not defining _enable, and/or defining it and setting it to !yes is a configuration that we support, so my preference would be for this whole test to go away. :) Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BB7BC9E.2060706>