From owner-freebsd-hackers@FreeBSD.ORG Thu Jan 15 06:54:32 2015 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 48943300; Thu, 15 Jan 2015 06:54:32 +0000 (UTC) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0060.outbound.protection.outlook.com [157.56.110.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7CCEE14C; Thu, 15 Jan 2015 06:54:30 +0000 (UTC) Received: from DM2PR0801MB0944.namprd08.prod.outlook.com (25.160.131.27) by DM2PR0801MB0944.namprd08.prod.outlook.com (25.160.131.27) with Microsoft SMTP Server (TLS) id 15.1.53.17; Thu, 15 Jan 2015 06:54:27 +0000 Received: from DM2PR0801MB0944.namprd08.prod.outlook.com ([25.160.131.27]) by DM2PR0801MB0944.namprd08.prod.outlook.com ([25.160.131.27]) with mapi id 15.01.0053.000; Thu, 15 Jan 2015 06:54:27 +0000 From: "Pokala, Ravi" To: "jhb@freebsd.org" , "eric@vangyzen.net" , "lars.engels@0x20.net" , "allanjude@freebsd.org" Subject: Re: [PATCH] Display progress during getmemsize() so the kernel doesn't look like it hanged Thread-Topic: [PATCH] Display progress during getmemsize() so the kernel doesn't look like it hanged Thread-Index: AQHQMJAa6jIVY6e0Rka/enbEqt4SMA== Date: Thu, 15 Jan 2015 06:54:26 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.4.7.141117 x-originating-ip: [24.6.178.251] authentication-results: spf=none (sender IP is ) smtp.mailfrom=rpokala@panasas.com; x-dmarcaction-test: None x-microsoft-antispam: BCL:0;PCL:0;RULEID:(3005004);SRVR:DM2PR0801MB0944; x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:; SRVR:DM2PR0801MB0944; x-forefront-prvs: 0457F11EAF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(13464003)(24454002)(51704005)(199003)(479174004)(189002)(377454003)(19580405001)(19580395003)(2501002)(83506001)(512954002)(106356001)(106116001)(105586002)(54356999)(2201001)(64706001)(46102003)(86362001)(99286002)(68736005)(101416001)(122556002)(102836002)(87936001)(2656002)(2900100001)(36756003)(40100003)(77156002)(97736003)(66066001)(92566002)(50986999)(62966003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0801MB0944; H:DM2PR0801MB0944.namprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: panasas.com does not designate permitted sender hosts) Content-Type: text/plain; charset="us-ascii" Content-ID: <1325952284E26D46B8B929DA86EA60D4@namprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: panasas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2015 06:54:26.5969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: acf01c9d-c699-42af-bdbb-44bf582e60b0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0801MB0944 Cc: "freebsd-hackers@freebsd.org" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2015 06:54:32 -0000 -----Original Message----- >Date: Tue, 13 Jan 2015 13:53:19 -0500 >From: John Baldwin >To: Eric van Gyzen , Lars Engels > , Allan Jude >Cc: freebsd-hackers@freebsd.org >Subject: Re: [PATCH] Display progress during getmemsize() so the > kernel doesn't look like it hanged >Message-ID: <3221643.2Qu3vC2WD5@ralph.baldwin.cx> >Content-Type: text/plain; charset=3D"us-ascii" > >On 1/13/15 10:48 AM, Eric van Gyzen wrote: >> On 01/13/2015 04:11, Lars Engels wrote: >>> On Mon, Jan 12, 2015 at 12:27:18AM -0500, Allan Jude wrote: >>>> Is this feature still useful with memtest.tests=3D0? >>> This feature is useful for everyone who has it set to 1, if they know >>> about it or not. So it's a very useful feature. >>=20 >> Agreed. >>=20 >> Comments on the patch: >>=20 >> The patch will divide by zero when PAGE_SIZE > 1 MiB. Maybe remove >> PAGES_PER_MB, and just use PAGES_PER_GB. Make it const, too. >>=20 >> The "total" line is mostly redundant with the later messages regarding >> "real memory" and "avail memory". I suggest removing it. > >I agree with these. One other nit is that FreeBSD tends to use all caps >for a macro rather than variables. Ravi, how about this variant, it >also only displays the dots if the memory test is enabled. Also, I >think the commit to disable the test should probably be merged to 10, yes. We have a winner. I regenerated the patch against 10-STABLE and attached it to the PR. Thanks all! -Ravi