From owner-p4-projects@FreeBSD.ORG Mon Jan 16 00:12:16 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id C7C8A16A422; Mon, 16 Jan 2006 00:12:15 +0000 (GMT) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B80116A41F for ; Mon, 16 Jan 2006 00:12:15 +0000 (GMT) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 514F543D46 for ; Mon, 16 Jan 2006 00:12:15 +0000 (GMT) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k0G0CFvZ031897 for ; Mon, 16 Jan 2006 00:12:15 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k0G0CFno031894 for perforce@freebsd.org; Mon, 16 Jan 2006 00:12:15 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Mon, 16 Jan 2006 00:12:15 GMT Message-Id: <200601160012.k0G0CFno031894@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Cc: Subject: PERFORCE change 89767 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2006 00:12:16 -0000 http://perforce.freebsd.org/chv.cgi?CH=89767 Change 89767 by rwatson@rwatson_peppercorn on 2006/01/16 00:12:13 Since we have a (up) pointer, use it. Found by: Coverity Prevent (tm) Affected files ... .. //depot/projects/trustedbsd/openbsm/libbsm/bsm_user.c#10 edit Differences ... ==== //depot/projects/trustedbsd/openbsm/libbsm/bsm_user.c#10 (text+ko) ==== @@ -214,7 +214,8 @@ /* Get user mask. */ if ((up = getauusernam_r(&u, username)) != NULL) { - if (-1 == getfauditflags(&u.au_always, &u.au_never, mask_p)) + if (-1 == getfauditflags(&up->au_always, &up->au_never, + mask_p)) return (-1); return (0); }