From owner-svn-src-all@freebsd.org Tue Oct 18 22:11:57 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 87F61C1785D; Tue, 18 Oct 2016 22:11:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qk0-x230.google.com (mail-qk0-x230.google.com [IPv6:2607:f8b0:400d:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 437C5C16; Tue, 18 Oct 2016 22:11:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qk0-x230.google.com with SMTP id f128so10036834qkb.1; Tue, 18 Oct 2016 15:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TIvQ3qYsDAThKXLyZ6MGj4rHmAaq9jOd243fJ3ZJ5yo=; b=ScsmUHd32tLV5YAgqwDh2KsVDOqTFxJuWpURFKfooD74qNZZFoCEvPEQHCEdgI6rNI lfeNzBjQ/C1H3k+RGm3Lm1VvHntKbLXtVPKPNODAC4qGYQFtA0lh4TSUyUGGJGvx1u// cF25aqCq7OK/TX7psAh54n3fWs2XSU/7IPQiRLILtmnd/W8MY3HiltGONRDCylOFz5f6 WUZsy5OSerEUC5RHRK6lkTwO/AepeYg9z/DX4veCjua9yHtH8Bl7LLEKsRS+i1SJEzjv Drpn5/dzPH45oqd0Ux5isBpfkfQ++sGH6kjbOS5nDC3R6BBotHrQCF50dexh55EhsEYt iBbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TIvQ3qYsDAThKXLyZ6MGj4rHmAaq9jOd243fJ3ZJ5yo=; b=QEcd5i+2Fe772VvRU013lzwUG0AJpfVaD7WbBgmnpEJDoiRnUJkHFdUqJsWQ/H3v1+ ssLRVoVeh9hAYDmjd1RdSvPnIo7+KXeXELyl7zvuiwBkymfZuvOcXxbFBPqJFPVhQ6FB ZxM4JYkxLARjYbAO4OCRoXne8az7vIBmcdxx6runQC3itj+G+aV0BP6bTsvpsKwh3jLL IgYOAqE5SW2lj6FS3ZPkumYAPV/clczc1fGS3fNRUBlbty11UtdJ5Hts56oSXl4Qing7 DrxxUjZFp2t5HTVBfNR3TJYtn39C3yYfsuNWZWGz1SM3ck72f+Bl/D6nZAzX3WuQdUOV GiZg== X-Gm-Message-State: AA6/9RlgX6Xdgh8+CMZaOP64xdmVK8KXR5p9lmMjty5Yin0K+QA6XbutQxx9K/TCmhD+fhOIhKX19K0ZoOEMeg== X-Received: by 10.55.41.39 with SMTP id p39mr3212798qkh.98.1476828716204; Tue, 18 Oct 2016 15:11:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.29.33 with HTTP; Tue, 18 Oct 2016 15:11:55 -0700 (PDT) In-Reply-To: <201610181013.u9IADs1j025157@repo.freebsd.org> References: <201610181013.u9IADs1j025157@repo.freebsd.org> From: Ngie Cooper Date: Tue, 18 Oct 2016 15:11:55 -0700 Message-ID: Subject: Re: svn commit: r307553 - head/contrib/netbsd-tests/lib/libpthread To: Ruslan Bukin Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 22:11:57 -0000 (Picking a "random commit") On Tue, Oct 18, 2016 at 3:13 AM, Ruslan Bukin wrote: > Author: br > Date: Tue Oct 18 10:13:54 2016 > New Revision: 307553 > URL: https://svnweb.freebsd.org/changeset/base/307553 > > Log: > Skip test on MIPS as it modifies TLS pointer in set_mcontext(). > > Discussed with: kib > Sponsored by: DARPA, AFRL > Sponsored by: HEIF5 > > Modified: > head/contrib/netbsd-tests/lib/libpthread/t_swapcontext.c > > Modified: head/contrib/netbsd-tests/lib/libpthread/t_swapcontext.c > ============================================================================== > --- head/contrib/netbsd-tests/lib/libpthread/t_swapcontext.c Tue Oct 18 10:12:55 2016 (r307552) > +++ head/contrib/netbsd-tests/lib/libpthread/t_swapcontext.c Tue Oct 18 10:13:54 2016 (r307553) > @@ -97,6 +97,15 @@ ATF_TC_BODY(swapcontext1, tc) > { > pthread_t thread; > > +#ifdef __mips__ > + /* > + * MIPS modifies TLS pointer in set_mcontext(), so > + * swapping contexts obtained from different threads > + * gives us different pthread_self() return value. > + */ > + atf_tc_skip("Platform is not supported."); > +#endif > + > oself = (void *)&val1; > nself = (void *)&val2; Please add appropriate conditionals to the code, i.e. - "#ifdef __FreeBSD__" / "#endif" around all blocks that are FreeBSD-specific, or need to be upstreamed to NetBSD. - "#ifdef __NetBSD__" / "#endif" around all blocks that are NetBSD-specific (i.e. test specific NetBSD requirements), do not need to be upstreamed. This helps mere mortals (like me) keep track of what's our's, what's their's, and what should be their's, so I can push back everything that should be in NetBSD to NetBSD. If it's not resolved by tonight, I'll work through the queue of items that need to be cleaned up. Thank you, -Ngie