From owner-p4-projects@FreeBSD.ORG  Thu Jul  6 13:39:00 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E93A516A4E6; Thu,  6 Jul 2006 13:38:59 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AC28316A4E1
	for <perforce@freebsd.org>; Thu,  6 Jul 2006 13:38:59 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5506243D68
	for <perforce@freebsd.org>; Thu,  6 Jul 2006 13:38:48 +0000 (GMT)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k66Dcm8D084806
	for <perforce@freebsd.org>; Thu, 6 Jul 2006 13:38:48 GMT
	(envelope-from piso@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k66DcmEe084803
	for perforce@freebsd.org; Thu, 6 Jul 2006 13:38:48 GMT
	(envelope-from piso@freebsd.org)
Date: Thu, 6 Jul 2006 13:38:48 GMT
Message-Id: <200607061338.k66DcmEe084803@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	piso@freebsd.org using -f
From: Paolo Pisati <piso@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 100750 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Jul 2006 13:39:00 -0000

http://perforce.freebsd.org/chv.cgi?CH=100750

Change 100750 by piso@piso_newluxor on 2006/07/06 13:38:32

	Better return code.

Affected files ...

.. //depot/projects/soc2005/libalias/sys/netinet/libalias/alias.c#6 edit

Differences ...

==== //depot/projects/soc2005/libalias/sys/netinet/libalias/alias.c#6 (text+ko) ====

@@ -1523,18 +1523,16 @@
         const char *error;
 	moduledata_t *p;
 
-	// XXX - mixing my own error code and errno.h is really
-	// a bad idea, convert everything to use errno.h
         handle = dlopen (path, RTLD_LAZY);
         if (!handle) {
             fputs (dlerror(), stderr);
-            return (-1);
+            return (EINVAL);
         }
 
 	p = dlsym(handle, "alias_mod");
         if ((error = dlerror()) != NULL)  {
             fputs(error, stderr);
-	    return (-1);
+	    return (EINVAL);
         }
 	
 	t = malloc(sizeof(struct dll));
@@ -1545,13 +1543,13 @@
 	if (attach_dll(t) == EEXIST) {
 		free(t);
 		fputs("dll conflict", stderr);
-		return (-1);
+		return (EEXIST);
 	}
 
         m = dlsym(t->handle, "handlers");
         if ((error = dlerror()) != NULL)  {
             fputs(error, stderr);
-	    return (-1);
+	    return (EINVAL);
         }       
 
 	attach_handlers(m);