From owner-svn-src-head@freebsd.org Thu Nov 30 20:31:14 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA8D9DB928B; Thu, 30 Nov 2017 20:31:13 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f174.google.com (mail-io0-f174.google.com [209.85.223.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A678573867; Thu, 30 Nov 2017 20:31:13 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f174.google.com with SMTP id s37so8892771ioe.10; Thu, 30 Nov 2017 12:31:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=JtQXvPtrrH/hAPkBJVXSfhJIXQObKsx9iUZMcJxFjTU=; b=qtDfr+sL6xzKeFcQfLq1GgxH5qEVNDSI1C4HxVOOqxNbrVtHS0yWGMISJMOrB4ayPP DsY4d7XjpfNHmAXvxjk0BlFMDTEGgE5uR4QAnXMokQvZ8E/c/tjepPEHyabekDg6xVGF AzwxwTrnoZRPmE7rJuAKL4c7FTcStZStQia+YcUkTLoxNEP/cKZGiizzH8lb9qOLNNYB lpx5BN9KAIJRGn6mrUg3hffu676oHNMNl9WdxXmhuCQQhHV0UwTXCeUNAT30Yqq87jsW 8b9i2FF7Cz4XyDYv7kFUEQxwAh0D2DckJ9T3kIiWOa+AAYxYqIKa9ipmKUiD6hx+CwoC rrVw== X-Gm-Message-State: AJaThX78kroxIOXQbRm4TqqUPbq6UiZhwmsZP2RMtNUn327TGm1z1ZTq aYsqIzu1v5Kp+Exy9RrsWaOwhK0r X-Google-Smtp-Source: AGs4zMaPQIXgIOSLqrdxFPUMgGfoYvb/3uGoODFg2hdqCp/TTB8mNCEmFUSiJ5/SVnO9D1MC5aLDXg== X-Received: by 10.107.222.20 with SMTP id v20mr9932587iog.48.1512073867536; Thu, 30 Nov 2017 12:31:07 -0800 (PST) Received: from mail-io0-f180.google.com (mail-io0-f180.google.com. [209.85.223.180]) by smtp.gmail.com with ESMTPSA id h140sm2224272iof.81.2017.11.30.12.31.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Nov 2017 12:31:07 -0800 (PST) Received: by mail-io0-f180.google.com with SMTP id d21so8916618ioe.7; Thu, 30 Nov 2017 12:31:07 -0800 (PST) X-Received: by 10.107.181.147 with SMTP id e141mr3464052iof.117.1512073867242; Thu, 30 Nov 2017 12:31:07 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.165.150 with HTTP; Thu, 30 Nov 2017 12:31:06 -0800 (PST) In-Reply-To: References: <201711300140.vAU1e7dC001292@repo.freebsd.org> From: Conrad Meyer Date: Thu, 30 Nov 2017 12:31:06 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r326383 - head/sys/x86/cpufreq To: Jung-uk Kim Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 20:31:14 -0000 On Thu, Nov 30, 2017 at 12:08 PM, Jung-uk Kim wrote: > On 11/30/2017 14:32, Conrad Meyer wrote: >> Hi, >> >> I don't think this answers the second question about the conditional. >> It seems like PCPU_GET() for the initial CPU should be pulled out of >> the loop, which binds the thread to a different CPU every iteration. > > Ah, good catch. I'll fix it soon. Sorry. Thanks! :-) >> Also, as a side effect of disabling verification, you have fixed PR >> 221621, 219213, and probably 218262. > > Probably. However, I am just trying to fix my FX-8350 and A10-6800 and > I don't have Zen processors to verify the MSRs are actually working on > those CPUs. I have one, I can verify if needed (although the change looks good to me). On some Zen systems (including mine) it seems that the hardware can successfully set a P-state, but will fail to read it back. For me it is P1 but other users have reported P0. That's the root issue of all of those PRs. If reading back isn't required, maybe that's a solution to the issue. Best, Conrad