Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Feb 2015 04:25:28 +0300
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Craig Rodrigues <rodrigc@FreeBSD.org>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Nikos Vassiliadis <nvass@gmx.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r276747 - head/sys/netpfil/pf
Message-ID:  <20150216012528.GA15484@FreeBSD.org>
In-Reply-To: <CAG=rPVd8VkPLHDQqBZPWmFA93%2BR26qUAwQGT2YUpxYJ8hZFJHA@mail.gmail.com>
References:  <201501060903.t06934qp081875@svn.freebsd.org> <20150122012709.GM15484@FreeBSD.org> <54C16715.6060701@gmx.com> <20150122222314.GO15484@FreeBSD.org> <CAG=rPVc2YLB-3ZyxDZTxDpkt6R8E_Sf1U%2BWWwKrFB2dxTXGENQ@mail.gmail.com> <20150215190100.GQ15484@FreeBSD.org> <CAG=rPVfK-Qmh7E_%2B-Mmo8kTrDWq=%2B%2ByVCzHNaQ=5pQh7aSaESQ@mail.gmail.com> <CAG=rPVd8VkPLHDQqBZPWmFA93%2BR26qUAwQGT2YUpxYJ8hZFJHA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 15, 2015 at 01:33:19PM -0800, Craig Rodrigues wrote:
C> By the way, it would be helpful if you could provide feedback in
C> Phabricator.  When I created those Phabricator reviews, I added
C> you as a reviewer to all of them, so you can't say that you didn't see
C> the patches.
C> You did not provide feedback on any of them:
C> 
C> https://reviews.freebsd.org/D1309
C> https://reviews.freebsd.org/D1312
C> https://reviews.freebsd.org/D1313
C> https://reviews.freebsd.org/D1315
C> 
C> Please take some time to go and provide feedback in those
C> reviews, so that a better patch can be made that makes you happy.

Did you address all problems that arised after code was committed?

Please do, otherwise my review would require me to cut-n-paste from
my own emails.

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150216012528.GA15484>