From owner-freebsd-bugs@freebsd.org  Fri Sep  9 11:56:16 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F98FBD0D34
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Fri,  9 Sep 2016 11:56:16 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0F4D8DF6
 for <freebsd-bugs@FreeBSD.org>; Fri,  9 Sep 2016 11:56:16 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u89BuFbP010376
 for <freebsd-bugs@FreeBSD.org>; Fri, 9 Sep 2016 11:56:15 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 211823] [patch] fsck_ffs incorrectly failing in check_cgmagic
Date: Fri, 09 Sep 2016 11:56:15 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 10.3-RELEASE
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: heckendorfc@gmail.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-211823-8-Zs20ywsXgA@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-211823-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-211823-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Sep 2016 11:56:16 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211823

--- Comment #2 from Christian Heckendorf <heckendorfc@gmail.com> ---
This patch may very well be wrong since I have no knowledge of UFS internals
but I assumed since these variables were being compared that the values were
compatible (the value of sblock.fs_ipg able to fit in a data type the size =
of
cgp->cg_old_niblk).

I don't see how comparing int16_t to uint32_t can be right :) Would you pre=
fer
to cast cgp->cg_old_niblk to uint32_t? As far as I could tell with a brief =
look
at their source, OpenBSD doesn't even compare these variables.

--=20
You are receiving this mail because:
You are the assignee for the bug.=