Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Jul 1999 14:40:19 -0600
From:      Nate Williams <nate@mt.sri.com>
To:        Alfred Perlstein <bright@rush.net>
Cc:        "Brian F. Feldman" <green@FreeBSD.ORG>, Nate Williams <nate@mt.sri.com>, hackers@FreeBSD.ORG, freebsd-ipfw@FreeBSD.ORG
Subject:   Re: securelevel and ipfw zero
Message-ID:  <199907282040.OAA03306@mt.sri.com>
In-Reply-To: <Pine.BSF.3.96.990728162234.20420I-100000@cygnus.rush.net>
References:  <Pine.BSF.4.10.9907281615560.92555-100000@janus.syracuse.net> <Pine.BSF.3.96.990728162234.20420I-100000@cygnus.rush.net>

next in thread | previous in thread | raw e-mail | index | archive | help
> > > *rant on*
> > > Brian, FreeBSD isn't your private playground for playing around, this is
> > > a group project, and you gotta follow the rules, or you don't get to
> > > play with the rest of the folks....
> > 
> > The rules don't say "leave the code that you work with in a bigger mess than
> > when you started." Cleaning up code is a fact of life, and it _NEEDS_ to be
> > done to get work done, very often. You have to learn to deal with that.
> > 
> > > *rant off*
> 
> and so it should remain, changes that provide readability to
> code should be committed, the only time documentation of code
> is wrong is when it it is incorrect.

The changes pointed out do *NOT* make the code more readable.  They just
move statements around for no reason, and change whitespace.

> Increasing the size of the cvs repo is not a consideration when
> worthwhile docs can be incorperated, especially when the person
> who needs to maintain it requires changess for readability.

Brian is *NOT* the maintainer, he is the author of a patch to it.

Doesn't anyone care for keeping the source code consistant *AND*
maintainable for multiple people, as well as maintaining a history of
*CHANGES* for people to review in the future?

Or is this Linux, where we don't give a rip and whatever the current
patch does to the rest of the tree is fine, since the more code we have
the better?



Nate


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ipfw" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907282040.OAA03306>