Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Jul 2005 14:51:52 +0000
From:      Oliver <urnenfel@tiscali.es>
To:        freebsd-bluetooth@freebsd.org
Subject:   Could check this?
Message-ID:  <20050729145152.6600.1@@vodafone.es>
In-Reply-To: <42E920D9.7050907@savvis.net>
References:  <20050728113713.2925.5@@vodafone.es> <42E90D5E.3030404@savvis.net> <20050728193757.15889.2@@vodafone.es> <42E920D9.7050907@savvis.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi,

In file ng_l2cap_llpi.c func ng_l2cap_lp_con_ind(...) 
concretely line:251:

	/* Create and send LP_ConnectRsp event */
	NG_MKMESSAGE(rsp, NGM_HCI_COOKIE, NGM_HCI_LP_CON_RSP,
		sizeof(*rp), M_NOWAIT);
	if (msg == NULL) {
		ng_l2cap_free_con(con);
		error = ENOMEM;
		goto out;
	}

NG_MKMESSAGE function creates a NG_MESSAGE called rsp? for being send with 
NG_SEND_MSG_HOOK afterwards, am I right?

if it is, shouldnt we be cheking the rsp pointer instead of msg ?
...the msg pointer is used much before in this func...so if it was NULL it 
should have crashed much before...

Am I missing something?

thanks,

		
______________________________________________ 
Renovamos el Correo Yahoo! 
Nuevos servicios, más seguridad 
http://correo.yahoo.es



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050729145152.6600.1>