From owner-svn-ports-all@FreeBSD.ORG Wed Apr 24 20:26:44 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E0AC8791; Wed, 24 Apr 2013 20:26:44 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ia0-x229.google.com (mail-ia0-x229.google.com [IPv6:2607:f8b0:4001:c02::229]) by mx1.freebsd.org (Postfix) with ESMTP id 88B281D21; Wed, 24 Apr 2013 20:26:44 +0000 (UTC) Received: by mail-ia0-f169.google.com with SMTP id l29so2070045iag.28 for ; Wed, 24 Apr 2013 13:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=8Gw6MHUq2RON/7JLWz2mQYO4d5iJUQLZJ0y4VpXTc7Q=; b=ziZTlE9Zk9sbpLHaG00PfyGUBV2hUJx63XZRWc24tWSeUCE2P+ve+Q9+nwxPkPod7T KE5cxWyWaHe7sQRgU8zcFineSpoI15rnWzGh+0g/qwqrYgVldEsIIbItalI3eh4swVW3 R6SRCDAcI4t3ms21CbGLmRawAQ6K9F9g1g0hzBIYUwyFNVyTc0n2AJoO+sfBkshEShVL gn2HwAbT0hclH5aLx1cLd2rp5G/8qXG74WoRx3h+9kQHaPak2XUoS4Kby8Lr56AuqOc6 a/l7vTBTRAWN3Cp4DI2Esa3JODltFK9+S4IasRvJloKe3tVyj/7dljE0xJDKPSahqaSH S6Dg== X-Received: by 10.50.42.165 with SMTP id p5mr29538611igl.75.1366835204178; Wed, 24 Apr 2013 13:26:44 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.64.58.52 with HTTP; Wed, 24 Apr 2013 13:26:14 -0700 (PDT) In-Reply-To: <51783462.4090904@FreeBSD.org> References: <201304241850.r3OIovPc079999@svn.freebsd.org> <51782B87.2090000@FreeBSD.org> <517830D2.5060600@FreeBSD.org> <51783462.4090904@FreeBSD.org> From: Chris Rees Date: Wed, 24 Apr 2013 21:26:14 +0100 X-Google-Sender-Auth: OsJTzgV_KM8WmC81ja0cKmK8Yro Message-ID: Subject: Re: svn commit: r316469 - head/databases/slony1v2 To: Jung-uk Kim Content-Type: text/plain; charset=ISO-8859-1 Cc: "svn-ports-head@freebsd.org" , svn-ports-all@freebsd.org, Jimmy Olgeni , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2013 20:26:45 -0000 On 24 April 2013 20:37, Jung-uk Kim wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 2013-04-24 15:30:57 -0400, Chris Rees wrote: >> On 24 April 2013 20:21, Jung-uk Kim wrote: >>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >>> >>> On 2013-04-24 15:08:00 -0400, Jimmy Olgeni wrote: >>>> >>>> On Wed, 24 Apr 2013, Jung-uk Kim wrote: >>>> >>>>> On 2013-04-24 14:50:57 -0400, Jimmy Olgeni wrote: >>>>>> Author: olgeni Date: Wed Apr 24 18:50:57 2013 New >>>>>> Revision: 316469 URL: >>>>>> http://svnweb.freebsd.org/changeset/ports/316469 >>>>>> >>>>>> Log: - Use bsd.port.options.mk. - PORTDOCS should not be >>>>>> conditional. - Whitespace fix. >>>>> ... >>>>> >>>>> bsd.port.mk says "(PORTDOCS) should not be set when no >>>>> documentation files are installed" and I believe it is >>>>> actually correct. >>>> >>>> I found this on the Porter's Handbook: >>>> >>>> If a directory is listed in PORTDOCS or matched by a glob >>>> pattern from this variable, the entire subtree of contained >>>> files and directories will be registered in the final packing >>>> list. If the DOCS option has been unset then files and >>>> directories listed in PORTDOCS would not be installed or added >>>> to port packing list. >>>> >>>> It seems to behave correctly, at least in the PORTDOCS=* case. >>> >>> It may work for now because bsd.options.mk has backward compat >>> shim, i.e., >>> >>> ## Now some compatibility .if empty(PORT_OPTIONS:MDOCS) >>> NOPORTDOCS= yes .endif >>> >>> It won't work when we deprecate the compat shims. >> >> Yes, bsd.port.mk needs fixing there. > > Agreed. > > We should refrain from blindly making PORTDOCS unconditional until we > resolve the issue, IMHO. Huh? It's not an issue at all, it's just that bsd.port.mk relies on a compat shim. Removing the compat shim would cause an issue, but we're not there yet, and it's a trivial fix. Including PORTDOCS conditionally has always been wrong. Chris