From owner-svn-src-all@freebsd.org Tue Oct 6 23:42:02 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E834E9D17DE; Tue, 6 Oct 2015 23:42:02 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mr11p00im-asmtp004.me.com (mr11p00im-asmtp004.me.com [17.110.69.135]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C7AF17E8; Tue, 6 Oct 2015 23:42:02 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from akita.hsd1.ca.comcast.net (c-73-162-13-215.hsd1.ca.comcast.net [73.162.13.215]) by mr11p00im-asmtp004.me.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NVT00I0OOHXP220@mr11p00im-asmtp004.me.com>; Tue, 06 Oct 2015 23:42:01 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-07_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 kscore.is_bulkscore=1.11022302462516e-16 compositescore=0.981618935876834 phishscore=0 kscore.is_spamscore=0 rbsscore=0.981618935876834 recipient_to_sender_totalscore=0 spamscore=0 urlsuspectscore=0.981618935876834 adultscore=0 kscore.compositescore=0 circleOfTrustscore=0 suspectscore=0 recipient_domain_to_sender_totalscore=0 bulkscore=0 recipient_domain_to_sender_domain_totalscore=0 recipient_to_sender_domain_totalscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1412110000 definitions=main-1510060266 Message-id: <1444174917.6210.43.camel@me.com> Subject: Re: svn commit: r288657 - head/sys/netinet6 From: Rui Paulo To: "Alexander V. Chernikov" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 06 Oct 2015 16:41:57 -0700 In-reply-to: <201510040821.t948LGH7000421@repo.freebsd.org> References: <201510040821.t948LGH7000421@repo.freebsd.org> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.16.5-1 MIME-version: 1.0 Content-transfer-encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 23:42:03 -0000 On Sun, 2015-10-04 at 08:21 +0000, Alexander V. Chernikov wrote: > Author: melifaro > Date: Sun Oct 4 08:21:15 2015 > New Revision: 288657 > URL: https://svnweb.freebsd.org/changeset/base/288657 > > Log: > Add __noinline attribute to several functions to ease dtrace > instrumentation > What instrumentation? Is there a DTrace script in userland that uses these functions? If not, this should not have been committed as you just made the code slower. This is one of those changes that should be kept in your own repository. -- Rui Paulo