Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 3 Jun 2016 08:49:05 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r301250 - stable/10/sys/dev/usb
Message-ID:  <201606030849.u538n5Dn021234@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Fri Jun  3 08:49:04 2016
New Revision: 301250
URL: https://svnweb.freebsd.org/changeset/base/301250

Log:
  MFC r299060:
  Extend the UQ_NO_STRINGS quirk to also cover the USB language string
  descriptor. This fixes enumeration of some older Samsung Galaxy S3
  phones.

Modified:
  stable/10/sys/dev/usb/usb_device.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/dev/usb/usb_device.c
==============================================================================
--- stable/10/sys/dev/usb/usb_device.c	Fri Jun  3 08:35:07 2016	(r301249)
+++ stable/10/sys/dev/usb/usb_device.c	Fri Jun  3 08:49:04 2016	(r301250)
@@ -1777,7 +1777,9 @@ usb_alloc_device(device_t parent_dev, st
 
 	scratch_ptr = udev->scratch.data;
 
-	if (udev->ddesc.iManufacturer ||
+	if (udev->flags.no_strings) {
+		err = USB_ERR_INVAL;
+	} else if (udev->ddesc.iManufacturer ||
 	    udev->ddesc.iProduct ||
 	    udev->ddesc.iSerialNumber) {
 		/* read out the language ID string */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201606030849.u538n5Dn021234>