From owner-svn-src-all@freebsd.org Sat Jul 29 20:52:58 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 109CBDCAF6A for ; Sat, 29 Jul 2017 20:52:58 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9827377CF9 for ; Sat, 29 Jul 2017 20:52:57 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: e2b3602b-749f-11e7-b2f5-7fbc454a3a22 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id e2b3602b-749f-11e7-b2f5-7fbc454a3a22; Sat, 29 Jul 2017 20:52:52 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v6TKqmsH001795; Sat, 29 Jul 2017 14:52:48 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1501361568.90400.100.camel@freebsd.org> Subject: Re: svn commit: r321633 - in head/sys/arm: arm include From: Ian Lepore To: Zbigniew Bodek Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sat, 29 Jul 2017 14:52:48 -0600 In-Reply-To: References: <201707272314.v6RNEHwQ033479@repo.freebsd.org> <1501344365.90400.99.camel@freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jul 2017 20:52:58 -0000 On Sat, 2017-07-29 at 22:11 +0200, Zbigniew Bodek wrote: > 2017-07-29 18:06 GMT+02:00 Ian Lepore : > > > > On Thu, 2017-07-27 at 23:14 +0000, Zbigniew Bodek wrote: > > > > > > Author: zbb > > > Date: Thu Jul 27 23:14:17 2017 > > > New Revision: 321633 > > > URL: https://svnweb.freebsd.org/changeset/base/321633 > > > > > > Log: > > >   Fix TEX index acquisition using L2 attributes > > > > > >   The TEX index is selected using (TEX0 C B) bits > > >   from the L2 descriptor. Use correct index by masking > > >   and shifting those bits accordingly. > > > > > >   Differential Revision:      https://reviews.freebsd.org/D11703 > > How did you guys discover this bug, like what were the symptoms? > Hello Ian, > > We had bug in usage of  pmap_remap_vm_attr() and fixing it didn't > help > for the issue so the second bug has been found here. > > > > >  Should we consider merging this to 11-stable? > As far as I know nobody besides Armada38x is using this function in > HEAD and nobody uses it in 11. > You may merge it to 11 though (just for the safety of this code in > the future). Cool, thanks.  We just imported 11-stable for use at $work, so I want to start from the most bug-free base we can.  :) -- Ian