Date: Mon, 16 Jul 2018 09:57:09 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Oleksandr Tymoshenko <gonzo@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336326 - head/sys/dev/ichiic Message-ID: <829a4a12-20d1-e48d-c338-9dd3f67a3969@FreeBSD.org> In-Reply-To: <201807160134.w6G1YkNR038303@repo.freebsd.org> References: <201807160134.w6G1YkNR038303@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/15/18 6:34 PM, Oleksandr Tymoshenko wrote: > Author: gonzo > Date: Mon Jul 16 01:34:45 2018 > New Revision: 336326 > URL: https://svnweb.freebsd.org/changeset/base/336326 > > Log: > Remove MODULE_PNP_INFO for ig4(4) driver > > ig4(4) does not support suspend/resume but present on the hardware where > such functionality is critical, like laptops. Remove PNP info to avoid > breaking suspend/resume on the systems where ig4(4) load is not explicitly > requested by the user. > > PR: 229791 > Reported by: Ali Abdallah I wonder if we don't want instead a way to tag a module as "don't autoload" so that you can still have a way to say "show me which unprobed devices have modules available". One option would be to have an rc.conf knob which is a regex that gets used with 'egrep -v' in the rc.d script on the output of devmatch. This has the slight advantage that a user can customize it via rc.conf. (For example, when working on cxgbe(4) on my dev boxes I don't want it to autoload, but in a production environment we might want it to autoload by default.) Another option might be to add some new type of PNP info that is a boolean "autoload" that defaults to true and teach devmatch to honor the boolean. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?829a4a12-20d1-e48d-c338-9dd3f67a3969>