From owner-cvs-all Sat Sep 14 20:18: 4 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B25E637B400 for ; Sat, 14 Sep 2002 20:18:02 -0700 (PDT) Received: from mail.speakeasy.net (mail17.speakeasy.net [216.254.0.217]) by mx1.FreeBSD.org (Postfix) with ESMTP id 54E0D43E72 for ; Sat, 14 Sep 2002 20:18:01 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 6326 invoked from network); 15 Sep 2002 03:17:57 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail17.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 15 Sep 2002 03:17:57 -0000 Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g8F3HxBv049704; Sat, 14 Sep 2002 23:17:59 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200209141855.g8EItBC9035815@freefall.freebsd.org> Date: Sat, 14 Sep 2002 23:18:01 -0400 (EDT) From: John Baldwin To: Nate Lawson Subject: RE: cvs commit: src/sys/kern kern_exec.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 14-Sep-2002 Nate Lawson wrote: > njl 2002/09/14 11:55:11 PDT > > Modified files: > sys/kern kern_exec.c > Log: > Move setugidsafety() call outside of process lock. This prevents a lock > recursion when closef() calls pfind() which also wants the proc lock. > This case only occurred when setugidsafety() needed to close unsafe files. > > Reviewed by: truckman Hmm, this is safe, but setugidsafety() has a race where it drops the filedesc lock around knote_fdclose(). Hmm, there actually is a race everywhere knote_fdclose() is called I think. I'll have to think about how to rework knote_fdclose(), knote_remove(), etc. to avoid the races. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message