Date: Fri, 15 Apr 2016 14:36:59 +0000 From: Howard Su <howard0su@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r298036 - head/sys/cam Message-ID: <CAAvnz_pNDxxvnxMy_mRagvnYQd2_w9FYM0XeAhXTwAqMr70j4w@mail.gmail.com> In-Reply-To: <CANCZdfrgfsKFfA0B=mX4WebtdPp1eH7jGo6YQGFKUzQ_hONKHg@mail.gmail.com> References: <201604150510.u3F5AWG7083767@repo.freebsd.org> <CAAvnz_pPvwnAt1NCw8QsOjKm_BFFmCPwaqpxbeVwsAg8--Z3JA@mail.gmail.com> <CANCZdfrgfsKFfA0B=mX4WebtdPp1eH7jGo6YQGFKUzQ_hONKHg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 15, 2016 at 9:26 PM Warner Losh <imp@bsdimp.com> wrote: > On Fri, Apr 15, 2016 at 12:05 AM, Howard Su <howard0su@gmail.com> wrote: > >> >> On Fri, Apr 15, 2016 at 1:10 PM Warner Losh <imp@freebsd.org> wrote: >> >>> Author: imp >>> Date: Fri Apr 15 05:10:32 2016 >>> New Revision: 298036 >>> URL: https://svnweb.freebsd.org/changeset/base/298036 >>> >>> Log: >>> Put function only used by CAM_NETFLIX_IOSCHED under that ifdef. >>> >>> I suggest to remove NETFLIX from the name. >> > > It's the Netflix I/O scheduler as opposed to the default one. So the > name is appropriate. It's better than CAM_WARNER_AWESOME_IOSCHED > which is the only other choice possible... :) > The name didn't give any information about what it is and what it do thing differently. Sounds like this is only useful for netflix and other people should not bother to use it. If so, this is proper name. > > Warner > > >> Modified: >>> head/sys/cam/cam_iosched.c >>> >>> Modified: head/sys/cam/cam_iosched.c >>> >>> ============================================================================== >>> --- head/sys/cam/cam_iosched.c Fri Apr 15 05:10:31 2016 (r298035) >>> +++ head/sys/cam/cam_iosched.c Fri Apr 15 05:10:32 2016 (r298036) >>> @@ -625,9 +625,11 @@ cam_iosched_cl_maybe_steer(struct contro >>> /* Periph drivers set these flags to indicate >>> work */ >>> #define CAM_IOSCHED_FLAG_WORK_FLAGS ((0xffffu) << 16) >>> >>> +#ifdef CAM_NETFLIX_IOSCHED >>> static void >>> cam_iosched_io_metric_update(struct cam_iosched_softc *isc, >>> sbintime_t sim_latency, int cmd, size_t size); >>> +#endif >>> >>> static inline int >>> cam_iosched_has_flagged_work(struct cam_iosched_softc *isc) >>> @@ -1522,6 +1524,7 @@ cam_iosched_update(struct iop_stats *iop >>> iop->sd = (int64_t)var < 0 ? 0 : isqrt64(var); >>> } >>> >>> +#ifdef CAM_NETFLIX_IOSCHED >>> static void >>> cam_iosched_io_metric_update(struct cam_iosched_softc *isc, >>> sbintime_t sim_latency, int cmd, size_t size) >>> @@ -1541,6 +1544,7 @@ cam_iosched_io_metric_update(struct cam_ >>> break; >>> } >>> } >>> +#endif >>> >>> #ifdef DDB >>> static int biolen(struct bio_queue_head *bq) >>> _______________________________________________ >>> svn-src-head@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/svn-src-head >>> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >>> >>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAAvnz_pNDxxvnxMy_mRagvnYQd2_w9FYM0XeAhXTwAqMr70j4w>