From owner-svn-src-all@freebsd.org Sun Oct 16 19:56:26 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 743D7C12A33; Sun, 16 Oct 2016 19:56:26 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-lf0-x229.google.com (mail-lf0-x229.google.com [IPv6:2a00:1450:4010:c07::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E9C991B08; Sun, 16 Oct 2016 19:56:25 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-lf0-x229.google.com with SMTP id x79so254888899lff.0; Sun, 16 Oct 2016 12:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=jkEKD0J3w8l3K5pvhDljO680OUFcHe5cYx6HlXEwQwo=; b=toPEQkulWLRwf4Os4fe6MOhf57kZVmsseMnG7GGxDZ7ujDxu/2ocwchOaBkd9IJHD+ PQuLG7PV3b1nWVlWPPhL2scHpfl98wBn5jzGO5gf0Rtw0StnGTE6eLFXdKQ060Y8Zytd fsVRdbC+ytzkAcLPk35nk0+dOK9YrKtddqLDctVpq8k7JYqUrp8nsu17DJvGk7vOSwTV VF5+HRvUaKO55td+3l+QLicdtq4tlM2j+p7IHzjAv1Y5IK37/x7UZ5KMFH9IPRcLjopD G8oUrSXwxf3w8jOgvYETYp1Gyx6iBMXSkhtB4PDhSCcI2ZRDaQAx1KiiyGzdLFdfBSdl xzgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=jkEKD0J3w8l3K5pvhDljO680OUFcHe5cYx6HlXEwQwo=; b=kbZSR2bdsmlglnqM2rBqkdkkyIqXtB9dvO8pSgbimS83X4WKaWadQUiQRTvKLZPTgo Jw7MoqLsiZVGdtwc4rlMpFT0+gOq93BX22QqZfd0U7hSkXnxxGNtBfE50MsfhLnWK+XM VM/fqShjjJ3p9tbQvIsJ2rGtpgUC2GMOUeAUbXYakVlAI/V5uJL157zniUvvJRY0t6fS ZZiiJAlBPmXjRWvkl+cUCU6lCMPCqd8Qan4L7+4a1CnrB1fL6kkNThLhVyFpuFIrPaTs Ob66czRjQ5NDtuTOXPmrAKvdpfzylC0rhawkTcXqEgwmCT5/dcB3K1eFb23FryxD/hJm bhrg== X-Gm-Message-State: AA6/9Rlpd8xUK8a2xKto+fyB4qvXOF9GMOugJy8i2m6O6qvd8ZZGTDZnQn7op31zsqlgEA== X-Received: by 10.25.200.199 with SMTP id y190mr9084614lff.40.1476647783932; Sun, 16 Oct 2016 12:56:23 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([134.249.139.101]) by smtp.gmail.com with ESMTPSA id g7sm6842432ljg.44.2016.10.16.12.56.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Oct 2016 12:56:23 -0700 (PDT) Sender: Alexander Motin Subject: Re: svn commit: r307397 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs To: Ngie Cooper References: <201610161849.u9GInFiY016740@repo.freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Alexander Motin Message-ID: <747353d9-06da-688c-2c4c-cc8ae5ade605@FreeBSD.org> Date: Sun, 16 Oct 2016 22:56:22 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2016 19:56:26 -0000 On 16.10.2016 22:48, Ngie Cooper wrote: > >> On Oct 16, 2016, at 11:49, Alexander Motin wrote: >> >> Author: mav >> Date: Sun Oct 16 18:49:15 2016 >> New Revision: 307397 >> URL: https://svnweb.freebsd.org/changeset/base/307397 >> >> Log: >> Add vfs.zfs.zil_log_limit sysctl. >> >> It is at least partially broken now, but that is another question. > > How is it broken? zl_itx_list_sz variable is not updated inside zil_async_to_sync(), that makes USE_SLOG() always return TRUE, ignoring value of zil_slog_limit. I am now trying to decide whether to fix that variable or rip it off. >> Modified: >> head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c >> >> Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c >> ============================================================================== >> --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c Sun Oct 16 18:27:41 2016 (r307396) >> +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c Sun Oct 16 18:49:15 2016 (r307397) >> @@ -924,6 +924,8 @@ uint64_t zil_block_buckets[] = { >> * Limit checking is disabled by setting zil_slog_limit to UINT64_MAX. >> */ >> uint64_t zil_slog_limit = 1024 * 1024; >> +SYSCTL_QUAD(_vfs_zfs, OID_AUTO, zil_slog_limit, CTLFLAG_RWTUN, >> + &zil_slog_limit, 0, "Maximal commit size to use SLOG"); >> #define USE_SLOG(zilog) (((zilog)->zl_logbias == ZFS_LOGBIAS_LATENCY) && \ >> (((zilog)->zl_cur_used < zil_slog_limit) || \ >> ((zilog)->zl_itx_list_sz < (zil_slog_limit << 1)))) >> -- Alexander Motin