From owner-svn-ports-all@freebsd.org Wed Mar 29 17:20:01 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8CE31D24FAD; Wed, 29 Mar 2017 17:20:01 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6DE4269511; Wed, 29 Mar 2017 17:20:01 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id B099166C3; Wed, 29 Mar 2017 17:19:30 +0000 (UTC) Date: Wed, 29 Mar 2017 17:19:30 +0000 From: Alexey Dokuchaev To: Mark Linimon Cc: Michael Gmelin , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r437089 - in head/devel: . hhdate hhdate/files Message-ID: <20170329171930.GA96917@FreeBSD.org> References: <201703272235.v2RMZKfx024323@repo.freebsd.org> <20170328142701.GA20879@FreeBSD.org> <20170328165708.3feecd6a@bsd64.grem.de> <20170329020527.GA8185@lonesome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170329020527.GA8185@lonesome.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 17:20:01 -0000 On Tue, Mar 28, 2017 at 09:05:27PM -0500, Mark Linimon wrote: > On Tue, Mar 28, 2017 at 04:57:08PM +0200, Michael Gmelin wrote: > > These are in to align to > > > > TEST_TEST_TARGET=test, otherwise it would look like this: > > > > TEST_USES= compiler:c++11-lib > > TEST_TEST_TARGET=test > > > > (replaced tabs by spaces for email) > > > > Would this actually be preferred? > > Keep in mind, "preferred" by danfe does not imply "preferred" by me, > or anyone else other than danfe. FWIW, I didn't use the word "preferred" at all in my reply, and yet Michael said it "makes sense". > If we expanded the PH to cover all danfe's objections, it would be > 600 pages long. Mark, come on. I'm not enforcing anything, and in fact you can find lots of examples of what I've said above already in the ports. You make it sound like I'm trying to formalize whether one must or must not put a after (len(knob) % 8) == 7) knobs, like OPTIONS_DEFAULT, which I'm certainly not. Again, I'm just trying to keep things consistent, not enforce any rules. Also, as you've surely noticed, when I try to explain why things are (IMHO) better be done one way than another I *always* try to bring some rationale behind it, and I'm open for a discussion. If people disagree, they are more than welcome to jump in and convince me otherwise. I don't want to control ports' style(9), but I do want ports to be 1) consistent, and 2) pretty looking (as long as #1 holds). You might argue that #2 is subjective, but history shows that most of the ports are (to my liking), and just some of them aren't. So again (sorry), it's mostly about consistency, not my "preferred" way of doing things. ./danfe