From owner-cvs-src@FreeBSD.ORG Thu Jul 6 21:53:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9CA4116A4E1; Thu, 6 Jul 2006 21:53:56 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B1FC43D45; Thu, 6 Jul 2006 21:53:55 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [10.10.3.185] ([69.15.205.254]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k66LrmKt022477; Thu, 6 Jul 2006 15:53:54 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <44AD8667.9090600@samsco.org> Date: Thu, 06 Jul 2006 15:53:43 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060206 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200607062142.k66LgaoV050809@repoman.freebsd.org> In-Reply-To: <200607062142.k66LgaoV050809@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=3.8 tests=none autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/linux32 syscalls.master src/sys/compat/linux linux_ioctl.c src/sys/i386/linux syscalls.master X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2006 21:53:56 -0000 John Baldwin wrote: > jhb 2006-07-06 21:42:36 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/linux32 syscalls.master > sys/compat/linux linux_ioctl.c > sys/i386/linux syscalls.master > Log: > - Protect the list of linux ioctl handlers with an sx lock. > - Hold Giant while calling linux ioctl handlers for now as they aren't all > known to be MPSAFE yet. > - Mark linux_ioctl() MPSAFE. > > Revision Changes Path > 1.15 +1 -1 src/sys/amd64/linux32/syscalls.master > 1.137 +17 -0 src/sys/compat/linux/linux_ioctl.c > 1.72 +1 -1 src/sys/i386/linux/syscalls.master Why not add the small bit of infrastucture so that modules can declare their handlers as MPSAFE or not? There are certainly some drivers that would benefit from this. Scott