Date: Thu, 11 Jul 2013 11:06:00 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Boris Samorodov <bsam@passap.ru> Cc: svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r322734 - in head: audio/pure-audio databases/pure-sql3 devel/pure-gen devel/pure-readline devel/pure-stldict devel/pure-stlvec graphics/pure-gl math/pure-mpfr math/pure-rational net/pu... Message-ID: <51DED7E8.8070309@FreeBSD.org> In-Reply-To: <51DED758.3080601@passap.ru> References: <201307102128.r6ALSvif091449@svn.freebsd.org> <51DED758.3080601@passap.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2OROLGXCEKFBNJSJQOTVW
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On 7/11/2013 11:03 AM, Boris Samorodov wrote:
> Hi All,
>=20
> 11.07.2013 01:28, Baptiste Daroussin =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>
>> Log:
>> Fix PORTSDIR not already defined by using relative path
> [...]
>> -.include "${PORTSDIR}/lang/pure/bsd.pure.mk"
>> +.include "${.CURDIR}/../../lang/pure/bsd.pure.mk"
>=20
> Can someone explain the rationale for this change?
>=20
> I'd say that ${PORTSDIR} _should_ work because all dependencies
> are registered via ${PORTSDIR}. And I like the former more because
> one may copy and play with a port at any directory without populating
> (a part of) the portstree.
>=20
> Thanks!
>=20
PORTSDIR is not defined _by default_ until bsd.port.mk is included on
the next line. So yes, using PORTSDIR is proper in dependencies, etc,
but when including the variable is not yet set.
--=20
Regards,
Bryan Drewery
------enig2OROLGXCEKFBNJSJQOTVW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJR3tfsAAoJEG54KsA8mwz5EkkQAJ/CLEMMDUpaHrP30sZx6idN
+1iT7FWR3WI0deMmjn5RR/SivZOPMbdraqW6wOfqqGH1A0x+zF0W8XLCdXfcR1lC
T4W3R8Orve+0FsbtEGOWedcVyW+N9lfnXeWpBxvZKzkc3GvIUg3F472Qd2sYRpRd
qDMWkm/IGuAoj9+efnSzZ4nRzBAxWDtk3WYoCWv/GfaeVXJbwq3Nhll8aJ85on5O
cErV5eMOcRnn+2qVxaVqatGprVpg6YnfnP9lw2WYYx2HkiNIh81nC8xz3+nIcNt9
U0y27lO+8oHKYp+BfMh0svRvwJbNGhpLhyGdGC7eAG/H9LwwcbQCvRJbocfKxqMi
KU/JrxhIDtZQhTLQgV6sf3zq+XBKlrKxvtX5xmMLY7PhVN3mfXRLfh7yDL1dOBKp
zHxz88Oi8E+8ynfRI/rBWbHinMAq3wDKTUwxc18Ur/yck06v40Ga+OmoQuKDzz0Y
KCnIc+CnwIPdDQDuovd7vwZiX9jtj7kcMcPaBFNuOc8gtkixVW/38IejkNEH6VRN
z7ph2HOt9kquiN9iLzPiO0XTobEZnLrrZ/NUKrApNS5EodBeI+tHH8NzZAMNpfFh
VeU7+JyKmACCNJ0PMvJzmhQLSSyQmIUmDJXPJHo16FCCgytDzcm0kKb5bJfBGuni
AvWbMRQ9C8t1P4zgtTOM
=VQOo
-----END PGP SIGNATURE-----
------enig2OROLGXCEKFBNJSJQOTVW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51DED7E8.8070309>