From owner-svn-ports-all@freebsd.org Thu May 24 10:44:00 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2015EEABDE0; Thu, 24 May 2018 10:44:00 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: from mail-qt0-f181.google.com (mail-qt0-f181.google.com [209.85.216.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B55FB8342C; Thu, 24 May 2018 10:43:59 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: by mail-qt0-f181.google.com with SMTP id f13-v6so1322185qtp.10; Thu, 24 May 2018 03:43:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6qS/tGSIQBaFd5g7LWSK3V3DFK3bIYulMPfEwshbEEU=; b=BkJfjGdt8dcfOSQ8ncn8m2/PzHpMFywq5mPhnwM9xYxRKG8cK4Fw1FsMNGrf/hpB2T Ep7kKUYDYnILc7xcjeYm/PuSCSuipeHCu59EC7D8oYzhGLDIyMtmft67Lnvs8iVdIzeB IAgSnrvZaK9qIgML4S46HbYef1sfYCwlnL+K33hZ+ETzRvqFphcCQQqKYVrh3nxKoh4L 1fsSbX03WyCAGoZnnSzcqrA/0oQ/utWc5Vn6hzw20e+8qQ8L/Qqv5UqQm2fXWae5M3B1 L+6rJHHRvZfe1KNKi+dGhXr4hnJAjPQ4ZlnskGS27erYVzSH+DXywCZtUSkSegvrvf0r ouuA== X-Gm-Message-State: ALKqPwcMdq8O1DsV0u3t1jJdQ6CslKU7/K/CG20REvvt3SmkhAgdzLat LQ17/F2roXINEa//ElVE2dipWZXU X-Google-Smtp-Source: ADUXVKJ20BmwyypfJtpqug2QincoWWgnr1U1x2wfhSFSUfKFmc8TIPukXWtDQYw/Zyvv4cWKHzAHIg== X-Received: by 2002:ac8:6108:: with SMTP id a8-v6mr6553241qtm.225.1527158638849; Thu, 24 May 2018 03:43:58 -0700 (PDT) Received: from mail-qt0-f172.google.com (mail-qt0-f172.google.com. [209.85.216.172]) by smtp.gmail.com with ESMTPSA id b134-v6sm10984932qkc.90.2018.05.24.03.43.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 May 2018 03:43:58 -0700 (PDT) Received: by mail-qt0-f172.google.com with SMTP id j1-v6so1340412qtp.2; Thu, 24 May 2018 03:43:58 -0700 (PDT) X-Received: by 2002:a0c:aa5c:: with SMTP id e28-v6mr6118212qvb.42.1527158638458; Thu, 24 May 2018 03:43:58 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac8:22b2:0:0:0:0:0 with HTTP; Thu, 24 May 2018 03:43:57 -0700 (PDT) In-Reply-To: <20180524065529.rtcmylbz5qtnupnx@atuin.in.mat.cc> References: <201805232159.w4NLxYrK000782@repo.freebsd.org> <1527143137.2894038.1383018096.245EB176@webmail.messagingengine.com> <20180524065529.rtcmylbz5qtnupnx@atuin.in.mat.cc> From: "Tobias C. Berner" Date: Thu, 24 May 2018 12:43:57 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r470725 - in head/textproc/tkdiff: . files To: Mathieu Arnold Cc: Tobias Kortkamp , =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 10:44:00 -0000 That was what I suggested initially. But as you commented on the target used to install the file without also weighing in on the issue of adding binaries, I assumed it was fine :) mfg Tobias On 24 May 2018 at 08:55, Mathieu Arnold wrote: > On Thu, May 24, 2018 at 06:25:37AM +0000, Tobias Kortkamp wrote: > > 2. print/jabref, misc/mc, editors/openoffice-devel, etc. seem to have > > binary files in files/*.png. Can we add new ones or is it forbidden > now? > > It seems weird to have to base64 encode icons and decode them during > the > > build. > > I think it would be better to keep binary files out of the ports tree. > It's probably as easy to drop them in LOCAL/user, either individually or > in an archive. > > -- > Mathieu Arnold >