Date: Sat, 27 Jan 2018 17:58:51 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328493 - head/lib/libthr/thread Message-ID: <7fe99389-750d-78f5-fd55-2c63bf814019@FreeBSD.org> In-Reply-To: <201801272227.w0RMRtmk062757@repo.freebsd.org> References: <201801272227.w0RMRtmk062757@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
For the record ... On 01/27/18 17:27, Pedro F. Giffuni wrote: > Author: pfg > Date: Sat Jan 27 22:27:55 2018 > New Revision: 328493 > URL: https://svnweb.freebsd.org/changeset/base/328493 > > Log: > libthr: Fix missing break in switch. > Hmm.. There is no "missing break" I just copy/pasted the Coverity report (a false positive). Sorry if that confused people. Pedro. > This is also a warning in recent GCC with -Wimplicit-fallthrough. > > CID: 1356262 > Obtained from: DragonFly (git 0f037c78 - partial) > > Modified: > head/lib/libthr/thread/thr_printf.c > > Modified: head/lib/libthr/thread/thr_printf.c > ============================================================================== > --- head/lib/libthr/thread/thr_printf.c Sat Jan 27 22:16:19 2018 (r328492) > +++ head/lib/libthr/thread/thr_printf.c Sat Jan 27 22:27:55 2018 (r328493) > @@ -95,6 +95,7 @@ next: c = *fmt++; > case 'p': > pstr(fd, "0x"); > islong = 1; > + /* FALLTHROUGH */ > case 'd': > case 'u': > case 'x': >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7fe99389-750d-78f5-fd55-2c63bf814019>