From owner-freebsd-hackers@freebsd.org Thu Jun 6 16:26:15 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F18015B8B67 for ; Thu, 6 Jun 2019 16:26:15 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E93207442A for ; Thu, 6 Jun 2019 16:26:13 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd44.google.com with SMTP id h6so691739ioh.3 for ; Thu, 06 Jun 2019 09:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WAOlqPGeZKLhq/3rz78UtbRjHo65cktuzwrn1//y2b4=; b=kvXSNxEBULJbpXoQulazwvQJ7YNLrNMAT2U4euPdJ0NR7K0vjwb6/ahWkRwlreI4oT 18J/ZpwNZCWV8+YIgfWsBRbJwiAPhVxoSOIh3sEVo+Qr1CSAgRjkkGawZ8UcipQMvkG4 qy1aXJgQLaaIDc9SUm8mts/2K/wbnK4OoWyLItjP7WvWPP8hBfQWDzwVz9aeiFHKZ8nV lbS+epsmekjyVp+LpFw22RvChc8LVRc6aEGeQRGDndqCEjx1sU3PPGNW7V0kiU8pVHay KK+lYtqW6WkPfP6uah5SsRhbZhD+SS/stWXFu/FufQQt88K0HOZlYn8bz9LqTrsKYeqn 2LGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=WAOlqPGeZKLhq/3rz78UtbRjHo65cktuzwrn1//y2b4=; b=bjgfMQxbOkgp1vRZf38rfAF9KA9NISTN8lFFTU+bUE13K804HJ3ktCGq35iLjGqukr l4zvafFQQSp3ecr42EO64tZtFHHZof3DDvq5EDuG9d4WIHkflki2ky9KxxTezWhS0trp spwfU+I8K0fDi7qAULwbuOTbf4m43dGPGNHzwTljCdm3n/U6cVzMcwSSooVsf9WBHxp4 rLfDRiqQ2aVgXEuBFf+FM2GXLYkYs6FA3Ul9gCmDjGgQYGIgevFl0GTY5fw7FRBz+XbO az/xlD+YvA0ViXnNc+sc1RxDCj52JlcCCW9CrrghFywhEYezBJHMkWbDtBrAy9wK/Mfm YDHw== X-Gm-Message-State: APjAAAUobQDaXFE8NeuLzyt++YM6GpHf1b/Ma3rXZ/UAlq+pRqs//KYe aNkoEhDRA+TvuJO/b5M8YVPsPbLm X-Google-Smtp-Source: APXvYqxJ32ZGR89gbAHQWYqBbZvU5rPuYLzPQIWpdXmSifaVGKYjZ/Y2ptJ5zUugTtnDbBu4iN1g1A== X-Received: by 2002:a5d:9e49:: with SMTP id i9mr12197570ioi.290.1559838372983; Thu, 06 Jun 2019 09:26:12 -0700 (PDT) Received: from raichu (toroon0560w-lp130-12-70-50-22-99.dsl.bell.ca. [70.50.22.99]) by smtp.gmail.com with ESMTPSA id d133sm1146077itc.27.2019.06.06.09.26.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 06 Jun 2019 09:26:12 -0700 (PDT) Sender: Mark Johnston Date: Thu, 6 Jun 2019 12:26:10 -0400 From: Mark Johnston To: Sebastian Huber Cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] if_lagg: Add INVARIANTS condition Message-ID: <20190606162610.GC4116@raichu> References: <20190605114110.30467-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190605114110.30467-1-sebastian.huber@embedded-brains.de> User-Agent: Mutt/1.12.0 (2019-05-25) X-Rspamd-Queue-Id: E93207442A X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=kvXSNxEB; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::d44 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-3.48 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.986,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[4.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; IP_SCORE(-0.78)[ip: (1.67), ipnet: 2607:f8b0::/32(-3.22), asn: 15169(-2.29), country: US(-0.06)] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jun 2019 16:26:15 -0000 On Wed, Jun 05, 2019 at 01:41:10PM +0200, Sebastian Huber wrote: > There is no need to call in_epoch() in case INVARIANTS is not defined. I committed this in r348745. > --- > sys/net/if_lagg.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sys/net/if_lagg.c b/sys/net/if_lagg.c > index 1a4d1d302ec..3e1cb2043b0 100644 > --- a/sys/net/if_lagg.c > +++ b/sys/net/if_lagg.c > @@ -1955,12 +1955,14 @@ lagg_link_active(struct lagg_softc *sc, struct lagg_port *lp) > * Search a port which reports an active link state. > */ > > +#ifdef INVARIANTS > /* > * This is called with either LAGG_RLOCK() held or > * LAGG_XLOCK(sc) held. > */ > if (!in_epoch(net_epoch_preempt)) > LAGG_XLOCK_ASSERT(sc); > +#endif > > if (lp == NULL) > goto search; > -- > 2.16.4 > > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"