From owner-svn-src-head@freebsd.org Sat Jan 27 23:02:22 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2C336EC8CDB; Sat, 27 Jan 2018 23:02:22 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f47.google.com (mail-it0-f47.google.com [209.85.214.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BED007EA63; Sat, 27 Jan 2018 23:02:21 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f47.google.com with SMTP id 196so5437713iti.5; Sat, 27 Jan 2018 15:02:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I/GnOTP7UbI++Hxa6lGaKTc9tY64cZ+vEypJ/vZZ8Xk=; b=PuPbXUvZTo03lNaFTjmdPwUDJVcZvmTEyPNG5+7U8Qi6xby/XLN2e/IVGXPYWL8W9h BbPFXWW9mqjJLlkIKFecL9E2zDudwls2be9I05Vb0qCOvApRmC+1gdnF2KGnPq6nQDZu LNPZ4YmPdPGV1nslKb5ejnoF7xgFQsvyraRyO9irZoWFb+EAbOS3bU0TLZ53OxF/kSDf /nbJ6ZqQW14xhaAwj+0CYRg1Wkd8ebva2Cdph8aMU9TwZ7tI9qS1CQowUPK/11ZZz7WB Y+Wo1q5Tmw/t5YFXaCFHGDVAhSSbdz4uY3PRsS/BD2o08JUBEEsWKSfBdTztiq7s/1rF J+YQ== X-Gm-Message-State: AKwxytd+iTl/V4rRHaaoAB43MiZ0m5eO269VbT1aqbI61bi4j+Fv+p5o 8HsuCDijiF+cDiHa7rdJylW0fTQj X-Google-Smtp-Source: AH8x224z7EU5cozHuDtyOgd4xbOOR9eyOKZwog5/k1ClJivz/2aNjmv5ceENf6g7gVaIjvseCxMmmg== X-Received: by 10.36.80.135 with SMTP id m129mr22562811itb.134.1517093787962; Sat, 27 Jan 2018 14:56:27 -0800 (PST) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com. [209.85.223.178]) by smtp.gmail.com with ESMTPSA id 82sm2223542iod.54.2018.01.27.14.56.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Jan 2018 14:56:27 -0800 (PST) Received: by mail-io0-f178.google.com with SMTP id m11so3964393iob.2; Sat, 27 Jan 2018 14:56:27 -0800 (PST) X-Received: by 10.107.35.84 with SMTP id j81mr19982242ioj.226.1517093787325; Sat, 27 Jan 2018 14:56:27 -0800 (PST) MIME-Version: 1.0 References: <201801271743.w0RHh9io022619@repo.freebsd.org> <1f1eb186-8f7b-6ec9-0970-d8b82b909e7b@FreeBSD.org> In-Reply-To: <1f1eb186-8f7b-6ec9-0970-d8b82b909e7b@FreeBSD.org> From: Conrad Meyer Date: Sat, 27 Jan 2018 22:56:17 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r328486 - head/usr.bin/fortune/fortune To: Pedro Giffuni Cc: cem@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jan 2018 23:02:22 -0000 I don=E2=80=99t think dragonfly has anything to do with this? If you=E2=80= =99re converting bool increments to setting true values in FreeBSD, use =E2=80=9Ctrue.=E2=80= =9D That=E2=80=99s all there is to it. Best, Conrad On Sat, Jan 27, 2018 at 1:44 PM Pedro Giffuni wrote: > Hi; > > > On 01/27/18 14:56, Conrad Meyer wrote: > > We can use 'true' and 'false' now. (style(9) also suggests using the > > C99 names instead of TRUE/FALSE.) > > Yes, I noticed that change in DragonflyBSD but it is conceptually a > different change and it deserves a different commit. > > Pedro. > > > On Sat, Jan 27, 2018 at 9:43 AM, Pedro F. Giffuni > wrote: > >> Author: pfg > >> Date: Sat Jan 27 17:43:09 2018 > >> New Revision: 328486 > >> URL: https://svnweb.freebsd.org/changeset/base/328486 > >> > >> Log: > >> fortune(6): Fix gcc80 -Wbool-operation warnings. > >> > >> Hinted by: Dragonfly (git > 4d1086765752f0569497d06460d95117c74f33ac) > >> > >> Modified: > >> head/usr.bin/fortune/fortune/fortune.c > >> > >> Modified: head/usr.bin/fortune/fortune/fortune.c > >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > >> --- head/usr.bin/fortune/fortune/fortune.c Sat Jan 27 17:24:59 > 2018 (r328485) > >> +++ head/usr.bin/fortune/fortune/fortune.c Sat Jan 27 17:43:09 > 2018 (r328486) > >> @@ -289,35 +289,35 @@ getargs(int argc, char *argv[]) > >> #endif /* DEBUG */ > >> switch(ch) { > >> case 'a': /* any fortune */ > >> - All_forts++; > >> + All_forts =3D TRUE; > >> break; > >> #ifdef DEBUG > >> case 'D': > >> Debug++; > >> break; > >> #endif /* DEBUG */ > >> - case 'e': > >> - Equal_probs++; /* scatter un-allocted prob > equally */ > >> + case 'e': /* scatter un-allocted prob > equally */ > >> + Equal_probs =3D TRUE; > >> break; > >> case 'f': /* find fortune files */ > >> - Find_files++; > >> + Find_files =3D TRUE; > >> break; > >> case 'l': /* long ones only */ > >> - Long_only++; > >> + Long_only =3D TRUE; > >> Short_only =3D FALSE; > >> break; > >> case 'o': /* offensive ones only */ > >> - Offend++; > >> + Offend =3D TRUE; > >> break; > >> case 's': /* short ones only */ > >> - Short_only++; > >> + Short_only =3D TRUE; > >> Long_only =3D FALSE; > >> break; > >> case 'w': /* give time to read */ > >> - Wait++; > >> + Wait =3D TRUE; > >> break; > >> case 'm': /* dump out the > fortunes */ > >> - Match++; > >> + Match =3D TRUE; > >> pat =3D optarg; > >> break; > >> case 'i': /* case-insensitive > match */ > >> > >