Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Aug 2002 15:22:07 +0300 (EEST)
From:      Maxim Sobolev <max@vega.com>
To:        ikostov@otel.net (Iasen Kostov)
Cc:        max@vega.com (Maxim Sobolev), julian@elischer.org (Julian Elischer), sobomax@FreeBSD.ORG (Maxim Sobolev), hackers@FreeBSD.ORG, net@FreeBSD.ORG
Subject:   Re: Increasing size of if_flags field in the ifnet structure [patch
Message-ID:  <200208161222.g7GCM8Rt005388@vega.vega.com>
In-Reply-To: <20020816150159.T18061-100000@shadowhand.OTEL.net> from "Iasen Kostov" at ΑΧΗ 16, 2002 

next in thread | previous in thread | raw e-mail | index | archive | help
> > There is no much point in this patch, because it will increase size of
> > struct  ifreq, which means that no ioctl's from older apps will be accepted
> > anyway. Therefore, there is no difference between those two, while my
> > approach is obviously cleaner.
> 
>   It does not increase size of struct ifreq.
>   This is a union not a struct as You see.

Oh, yes, you are obviously correct. However, I still wonder if your patch
is endianless-safe.

-Maxim

>         union {
>                 struct  sockaddr ifru_addr;
>                 struct  sockaddr ifru_dstaddr;
>                 struct  sockaddr ifru_broadaddr;
>                 short   ifru_flags[2];
>                 int     ifru_flagslong;
>                 int     ifru_metric;
>                 int     ifru_mtu;
>                 int     ifru_phys;
>                 int     ifru_media;
>                 caddr_t ifru_data;
>                 int     ifru_cap[2];
>         } ifr_ifru;
> >
> > -Maxim
> >
> > >
> > > On Thu, 15 Aug 2002, Julian Elischer wrote:
> > >
> > > > you cannot break ABIs in 4.x
> > > > in 5.x it will probably be ok until (say) 5.1 or something.
> > > >
> > > >
> > > > On Thu, 15 Aug 2002, Maxim Sobolev wrote:
> > > >
> > > > > Folks,
> > > > >
> > > > > When implementing ability to switch interface into promisc mode using
> > > > > ifconfig(8) I've stumbled into the problem with already exhausted
> > > > > space in the `short if_flags' field in the ifnet structure. I need to
> > > > > allocate one new flag, while we already have 16 IFF_* flags, and even
> > > > > one additional flag which is implemented using currently free
> > > > > if_ipending field of the said structure. Attached patch is aimed at
> > > > > increasing size of if_flags to 32 bits, as well as to clean-up
> > > > > if_ipending abuse. Granted, it will break backward ABI compatibility,
> > > > > but IMO it is not a big problem.
> > > > >
> > > > > Comments and suggestions are greatly appreciated. Thanks!
> > > > >
> > > > > -Maxim
> > > >
> > > >
> > > > To Unsubscribe: send mail to majordomo@FreeBSD.org
> > > > with "unsubscribe freebsd-net" in the body of the message
> > > >
> > >
> >
> >
> > To Unsubscribe: send mail to majordomo@FreeBSD.org
> > with "unsubscribe freebsd-net" in the body of the message
> >
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200208161222.g7GCM8Rt005388>