Date: Sun, 19 Jun 2011 14:09:34 -0400 From: Alexander Kabaev <kabaev@gmail.com> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r223124 - head/lib/libstand Message-ID: <20110619140934.08375095@kan.dnsalias.net> In-Reply-To: <201106152213.p5FMDMWP000491@svn.freebsd.org> References: <201106152213.p5FMDMWP000491@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/ilJimhLH9t.o+OsibXxI69z Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 15 Jun 2011 22:13:22 +0000 (UTC) Craig Rodrigues <rodrigc@FreeBSD.org> wrote: > Author: rodrigc > Date: Wed Jun 15 22:13:22 2011 > New Revision: 223124 > URL: http://svn.freebsd.org/changeset/base/223124 >=20 > Log: > (1) When sending the TFTP RRQ packet to read a file, > send along the "blksize" option specified in RFC2348, > and the "tsize" option specified in RFC2349. > =20 > Add code to parse the TFTP Option Acknowledgement (OACK) > packet as specified in RFC2347. > =20 > For TFTP servers which support the "blksize" option, we can > specify a TFTP Data block size larger than the default 512 > bytes specified in RFC1350. This offers greater read performance when > downloading files. > =20 > We request an initial size of 1428 bytes, which is less than > the Ethernet MTU of 1500 bytes. If the TFTP server sends back an OACK > packet, then use the block size specified in the OACK packet. > Most times it is usually the same value as what we request. > If the TFTP server supports RFC2348, we will see performance > improvements by transferring files over TFTP with larger block sizes. > =20 > If we do not get back an OACK packet, then we most likely we > are interoperating with a legacy TFTP server that does not > support TFTP extension options, so default to the block size of > 512 bytes. > =20 > (2) If the "tftp.blksize" environment variable is set, then > take that value and use it when sending the TFTP RRQ packet, > instead of 1428. This allows us to set different values of > "tftp.blksize" in the loader, so that we can test out different > TFTP block sizes at run time. > =20 > Obtained from: Juniper Networks > Fixed by: rodrigc >=20 Has this code been reviewed by anyone outside of Juniper? --=20 Alexander Kabaev --Sig_/ilJimhLH9t.o+OsibXxI69z Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iD8DBQFN/jtkQ6z1jMm+XZYRAkPjAJwNCaXWx//1zVtErp9TxMC7JsaReACgsWda YJc3I++q8CjXfupQNUTyVNc= =kwQG -----END PGP SIGNATURE----- --Sig_/ilJimhLH9t.o+OsibXxI69z--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110619140934.08375095>