Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Jul 1999 14:42:35 -0600
From:      Nate Williams <nate@mt.sri.com>
To:        "Brian F. Feldman" <green@FreeBSD.org>
Cc:        Nate Williams <nate@mt.sri.com>, hackers@FreeBSD.org, freebsd-ipfw@FreeBSD.org
Subject:   Re: securelevel and ipfw zero
Message-ID:  <199907282042.OAA03370@mt.sri.com>
In-Reply-To: <Pine.BSF.4.10.9907281627470.92555-100000@janus.syracuse.net>
References:  <199907282024.OAA03102@mt.sri.com> <Pine.BSF.4.10.9907281627470.92555-100000@janus.syracuse.net>

Next in thread | Previous in thread | Raw E-Mail | Index | Archive | Help
> > > > > These were changes that were necessary to make ipfw readable enough that
> > > > > I could work with it in this area. They aren't just to clean it up, or
> > > > > just for change's sake. They need to stay in.
> > > > 
> > > > C'mon now, re-ording the lines is *certainly* not necessary to work.
> > > 
> > > That's true. I sure didn't do that.
> > 
> > Sure looks like you did.  There are white-space and re-ordering
> > modifications in the diffs you sent out.  If you didn't do them, who
> > did?
> 
> I refuse to justify putting variables in a function I changed in the
> right place.

This and other obnoxious responses to valid responses makes me want to
ask for your commit privileges.  You obviously don't care what anyone
else has done.

> > In particular, the changes I pointed out are not 'cleanups', but style
> > changes.
> 
> When you make code readable, it's a cleanup.

The code is *NO* more readable by you re-ordering lines and changes
whitespace.

Grow up and quit acting like a child who doesn't wanna follow the rules.



Nate


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ipfw" in the body of the message




Want to link to this message? Use this URL: <http://docs.FreeBSD.org/cgi/mid.cgi?199907282042.OAA03370>