Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Sep 2006 15:28:16 -0400
From:      Kris Kennaway <kris@obsecurity.org>
To:        Stanislav Sedov <stas@FreeBSD.org>
Cc:        Michael Johnson <ahze@ahze.net>, shaun@freebsd.org, cvs-all@freebsd.org, Mario Sergio Fujikawa Ferreira <lioux@freebsd.org>, Kris Kennaway <kris@obsecurity.org>, cvs-ports@freebsd.org, ports-committers@freebsd.org
Subject:   Re: cvs commit: ports/multimedia/ffmpeg-devel Makefile ports/multimedia/ffmpeg-devel/files patch-libavcodec_x264.c patch-libavformat_movenc.c
Message-ID:  <20060929192816.GA34619@xor.obsecurity.org>
In-Reply-To: <20060929232451.5781ed0c@localhost>
References:  <200609250047.k8P0leLL009808@repoman.freebsd.org> <20060925005252.GA50714@xor.obsecurity.org> <20060929004121.GA60887@xor.obsecurity.org> <b2203fed0609290422s7b2fd0a1h43ce94361ec7452c@mail.gmail.com> <b2203fed0609290423y70c59869t66b5ca98e4d3c372@mail.gmail.com> <20060929172834.GB31887@xor.obsecurity.org> <20060929232451.5781ed0c@localhost>

next in thread | previous in thread | raw e-mail | index | archive | help

--jI8keyz6grp/JLjh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 29, 2006 at 11:24:51PM +0400, Stanislav Sedov wrote:
> On Fri, 29 Sep 2006 13:28:34 -0400
> Kris Kennaway <kris@obsecurity.org> mentioned:
>=20
> > On Fri, Sep 29, 2006 at 07:23:46AM -0400, Michael Johnson wrote:
> > > On 9/29/06, Michael Johnson <ahze@ahze.net> wrote:
> > > >
> > > >
> > > >
> > > >On 9/28/06, Kris Kennaway <kris@obsecurity.org> wrote:
> > > >>
> > > >> On Sun, Sep 24, 2006 at 08:52:52PM -0400, Kris Kennaway wrote:
> > > >> > On Mon, Sep 25, 2006 at 12:47:40AM +0000, Mario Sergio Fujikawa
> > > >> Ferreira wrote:
> > > >> > > lioux       2006-09-25 00:47:40 UTC
> > > >> > >
> > > >> > >   FreeBSD ports repository
> > > >> > >
> > > >> > >   Modified files:
> > > >> > >     multimedia/ffmpeg-devel Makefile
> > > >> > >     multimedia/ffmpeg-devel/files patch-libavcodec_x264.c
> > > >> > >   Added files:
> > > >> > >     multimedia/ffmpeg-devel/files patch-libavformat_movenc.c
> > > >> > >   Log:
> > > >> > >   Fix build on 4.x: fix devel/sdl header include
> > > >> > >
> > > >> > >   PR:             102431
> > > >> > >   Submitted by:   Shaun Amott <shaun@FreeBSD.org >
> > > >> >
> > > >> > Are you sure this is still correct after the recent SDL changes?
> > > >> >
> > > >> > Kris
> > > >>
> > > >> Ping.  It appears to be broken.
> > > >
> > > >
> > > patch-libavcodec_x264.c needs to be readded. It's there but it's empt=
y.
> >=20
> > Maybe so, but the Makefile also explicitly patches it to #include
> > <SDL11/...> too, which is the wrongness I was referring to (SDL
> > headers are now in <SDL/...>.
> >=20
> > Kris
>=20
> It seems to me I've eliminated these strings in my mega SDL patch
> and 1.94 builds successfully for me. Why it was introduced again in
> 1.95?

Yes, that's the error.

Kris

--jI8keyz6grp/JLjh
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)

iD8DBQFFHXPQWry0BWjoQKURAhXwAKCvJYbC1R0TUiXK/ct1UdAqiyNTlgCfahY5
KwekNLcekQaTjBSbYGtNa54=
=CaMx
-----END PGP SIGNATURE-----

--jI8keyz6grp/JLjh--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060929192816.GA34619>