Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Feb 2017 16:52:58 +0000 (UTC)
From:      Allan Jude <allanjude@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r314213 - head/sys/boot/geli
Message-ID:  <201702241652.v1OGqwDi055133@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: allanjude
Date: Fri Feb 24 16:52:57 2017
New Revision: 314213
URL: https://svnweb.freebsd.org/changeset/base/314213

Log:
  Remove control+r handling from geliboot's pwgets()
  
  pwgets() is based on ngets() from libstand, which includes a feature
  that is not wanted in a very of the function designed for password
  handling.
  
  Pressing control+r echos out the entered string
  
  This commit removes that feature from pwgets()
  
  PR:		217298
  Reported by:	ehaupt
  Reviewed by:	kristof, tsoome, ehaupt
  Sponsored by:	ScaleEngine Inc.
  Differential Revision:	https://reviews.freebsd.org/D9782

Modified:
  head/sys/boot/geli/pwgets.c

Modified: head/sys/boot/geli/pwgets.c
==============================================================================
--- head/sys/boot/geli/pwgets.c	Fri Feb 24 16:37:35 2017	(r314212)
+++ head/sys/boot/geli/pwgets.c	Fri Feb 24 16:52:57 2017	(r314213)
@@ -60,14 +60,6 @@ pwgets(char *buf, int n)
 		putchar('\b');
 	    }
 	    break;
-	case 'r'&037: {
-	    char *p;
-
-	    putchar('\n');
-	    for (p = buf; p < lp; ++p)
-		putchar(*p);
-	    break;
-	}
 	case 'u'&037:
 	case 'w'&037:
 	    lp = buf;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702241652.v1OGqwDi055133>