From owner-svn-src-head@freebsd.org  Fri Feb 24 16:52:59 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2F425CEC851;
 Fri, 24 Feb 2017 16:52:59 +0000 (UTC)
 (envelope-from allanjude@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id F2A961F70;
 Fri, 24 Feb 2017 16:52:58 +0000 (UTC)
 (envelope-from allanjude@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v1OGqwEh055134;
 Fri, 24 Feb 2017 16:52:58 GMT (envelope-from allanjude@FreeBSD.org)
Received: (from allanjude@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id v1OGqwDi055133;
 Fri, 24 Feb 2017 16:52:58 GMT (envelope-from allanjude@FreeBSD.org)
Message-Id: <201702241652.v1OGqwDi055133@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: allanjude set sender to
 allanjude@FreeBSD.org using -f
From: Allan Jude <allanjude@FreeBSD.org>
Date: Fri, 24 Feb 2017 16:52:58 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r314213 - head/sys/boot/geli
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Feb 2017 16:52:59 -0000

Author: allanjude
Date: Fri Feb 24 16:52:57 2017
New Revision: 314213
URL: https://svnweb.freebsd.org/changeset/base/314213

Log:
  Remove control+r handling from geliboot's pwgets()
  
  pwgets() is based on ngets() from libstand, which includes a feature
  that is not wanted in a very of the function designed for password
  handling.
  
  Pressing control+r echos out the entered string
  
  This commit removes that feature from pwgets()
  
  PR:		217298
  Reported by:	ehaupt
  Reviewed by:	kristof, tsoome, ehaupt
  Sponsored by:	ScaleEngine Inc.
  Differential Revision:	https://reviews.freebsd.org/D9782

Modified:
  head/sys/boot/geli/pwgets.c

Modified: head/sys/boot/geli/pwgets.c
==============================================================================
--- head/sys/boot/geli/pwgets.c	Fri Feb 24 16:37:35 2017	(r314212)
+++ head/sys/boot/geli/pwgets.c	Fri Feb 24 16:52:57 2017	(r314213)
@@ -60,14 +60,6 @@ pwgets(char *buf, int n)
 		putchar('\b');
 	    }
 	    break;
-	case 'r'&037: {
-	    char *p;
-
-	    putchar('\n');
-	    for (p = buf; p < lp; ++p)
-		putchar(*p);
-	    break;
-	}
 	case 'u'&037:
 	case 'w'&037:
 	    lp = buf;