Date: Sat, 11 Jan 2003 21:03:59 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: Alfred Perlstein <bright@mu.org> Cc: Jake Burkholder <jake@locore.ca>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_acl.c kern_descrip.c kern_event.c kern_mac.c sys_pipe.c sys_socket.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c vfs_aio.c vfs_syscalls.c vfs_vnops.c src/sys/netgraph ng_socket.c src/sys/sys file.h src/sys/ufs/ffs ... Message-ID: <200301120503.h0C53xTg052104@apollo.backplane.com> References: <200301120137.h0C1bD0E098037@repoman.freebsd.org> <20030111213259.E212@locore.ca> <200301120254.h0C2srcS043241@apollo.backplane.com> <20030112040835.GA33821@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
:
:* Matthew Dillon <dillon@apollo.backplane.com> [030111 18:55] wrote:
:>
:> It's a cleanup. Ugliness I noticed as I was evaluating how easy it
:> would be to add a memory object file type. I don't see why you believe
:> a justification is required other then cleanup and code readability.
:> void *'s are things you only use when you need to. We certainly didn't
:> need to here. How exactly is this commit so bad that you are against it?
:
:What about third party/loadable DTYPEs? Isn't this more annoying
:than helpful for that case? You've also broken the style of this
:file by removing the f_ prefix. Please fix.
:
:--
:-Alfred Perlstein [alfred@freebsd.org]
I will also point out that although the union is using named structures,
the structures themselves are only used as pointers and therefore are
opaque. Any third party struct file pointer structure that we
incorporate in the main tree can be added to sys/file.h
as 'struct blah;' without introducing any include file dependancies,
whether the third party module is compiled in or not (hence it not being
a layering violation).
Any truely third party code would have to use un_data.generic, but
that is nothing more then a #define in the third party module's header
file. We could also #define f_data to un_data.generic in sys/file.h
(for #ifdef KERNEL code only to avoid pollution) and while I didn't do
it, I left that option open on purpose.
-Matt
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301120503.h0C53xTg052104>