Date: Mon, 5 Jul 1999 11:40:02 -0700 (PDT) From: Juergen Lock <nox@jelal.kn-bremen.de> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/10064: /bin/sh called from make dumps core Message-ID: <199907051840.LAA24152@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/10064; it has been noted by GNATS. From: Juergen Lock <nox@jelal.kn-bremen.de> To: Sheldon Hearn <sheldonh@uunet.co.za> Cc: Juergen Lock <nox@jelal.kn-bremen.de>, freebsd-gnats-submit@freebsd.org Subject: Re: bin/10064: /bin/sh called from make dumps core Date: Mon, 5 Jul 1999 19:23:47 +0200 On Mon, Jul 05, 1999 at 10:19:13AM +0200, Sheldon Hearn wrote: > On Sun, 04 Jul 1999 12:44:15 +0200, Juergen Lock wrote: > > > Hmm so let's find out which patch makes it dissapear. After building > > several sh:s from the RELENG_2_2 branch i found out the 2.2.7R sh > > dies and the 2.2.8R sh doesn't, and the crucial patch is in parser.c > > (0parser228 below). undoing that patch in the 3.2-stable sh as well > > as in the -current sh cause both to crash, and that patch doesn't > > look like it could fix a stack bug, only mask it by using the stack > > differently, right? > > Surely one way to fix a stack bug is to use the stack differently? :-) Well what i meant was that parser.c patch probably only changes the amount of stack used for that particular sh command and so the crash disappears, but now a different sh command would still cause a crash. Finding that kind of different sh command without really knowing the innards of sh was much more difficult than just including the (reversed) parser.c patch, so thats what i did. > > I think the important thing, as you've discovered for yourself, is that > it's fixed in 2.2.8-RELEASE, 3.2-STABLE and 4.0-CURRENT. Thanks for the > feedback. It is fixed for this particular sh command, but is it really fixed for all possible sh commands? Someone who knows the sh code better than both of us :) should answer this i think. Regards, -- Juergen Lock <nox.foo@jelal.kn-bremen.de> (remove dot foo from address to reply) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907051840.LAA24152>