From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Jan 22 13:10:07 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E701116A41F for ; Sun, 22 Jan 2006 13:10:07 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id ECA0A43D4C for ; Sun, 22 Jan 2006 13:10:06 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k0MDA6AN056475 for ; Sun, 22 Jan 2006 13:10:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k0MDA6Ww056446; Sun, 22 Jan 2006 13:10:06 GMT (envelope-from gnats) Date: Sun, 22 Jan 2006 13:10:06 GMT Message-Id: <200601221310.k0MDA6Ww056446@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Jonathan Weiss Cc: Subject: Re: ports/92072: databases/rubygem-activerecord: MySQL options & portlint(1) cleanup X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jonathan Weiss List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jan 2006 13:10:08 -0000 The following reply was made to PR ports/92072; it has been noted by GNATS. From: Jonathan Weiss To: bug-followup@FreeBSD.org, roderick@developer.nedforce.nl, edwin@FreeBSD.org Cc: Subject: Re: ports/92072: databases/rubygem-activerecord: MySQL options & portlint(1) cleanup Date: Sun, 22 Jan 2006 14:07:37 +0100 Cheers, The patch looks ok, I've updated it to include support for PostgreSQL and SQLite3 bindings: ------------------------------------- Index: Makefile =================================================================== RCS file: /home/ncvs/ports/databases/rubygem-activerecord/Makefile,v retrieving revision 1.5 diff -u -r1.5 Makefile --- Makefile 21 Jan 2006 20:25:05 -0000 1.5 +++ Makefile 22 Jan 2006 11:20:03 -0000 @@ -6,17 +6,37 @@ PORTNAME= activerecord PORTVERSION= 1.13.2 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= databases rubygems +MASTER_SITES= http://rubyforge.org/frs/download.php/7641/ MAINTAINER= jw@innerewut.de COMMENT= Object-relational mapping layer for Rails MVC Framework -MASTER_SITES= http://rubyforge.org/frs/download.php/7641/ - BUILD_DEPENDS= ${LOCALBASE}/${SPEC_DIR}/activesupport-1.2.5.gemspec:${PORTSDIR}/devel/rubygem-activesupport RUN_DEPENDS= ${BUILD_DEPENDS} +OPTIONS= NATIVE_MYSQL "Use native MySQL bindings" Off\ + NATIVE_POSTGRESQL "Use native PostgreSQL bindings" Off\ + NATIVE_SQLITE3 "Use native SQLite3 bindings" Off +OPTIONSFILE= ${PORT_DBDIR}/rubygem-${PORTNAME}/options + +# to get RUBY_SITEARCHLIBDIR +USE_RUBY= yes + .include + +.if defined(WITH_NATIVE_MYSQL) +RUN_DEPENDS+= ${RUBY_SITEARCHLIBDIR}/mysql.so:${PORTSDIR}/databases/ruby-mysql +.endif + +.if defined(WITH_NATIVE_POSTGRESQL) +RUN_DEPENDS+= ${RUBY_SITEARCHLIBDIR}/postgres.so:${PORTSDIR}/databases/ruby-postgres +.endif + +.if defined(WITH_NATIVE_SQLITE3) +RUN_DEPENDS+= ${RUBY_SITEARCHLIBDIR}/sqlite3_api.so:${PORTSDIR}/databases/ruby-sqlite3 +.endif + .include "${PORTSDIR}/devel/ruby-gems/Makefile.common" .include ------------------------------------- Regards, Jonathan -- Jonathan Weiss http://blog.innerewut.de