Date: Thu, 7 Feb 2019 12:35:12 +0100 From: Rodrigo Osorio <rodrigo@FreeBSD.org> To: Tobias Kortkamp <tobik@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r492359 - head/graphics/ufraw Message-ID: <ddc6bb0c-dc47-6ad5-3392-5b939b037ae8@FreeBSD.org> In-Reply-To: <20190207111431.GA66860@urd.tobik.me> References: <201902071102.x17B2ksi050848@repo.freebsd.org> <20190207111431.GA66860@urd.tobik.me>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/7/19 12:14 PM, Tobias Kortkamp wrote: > > On Thu, Feb 7, 2019, at 12:02, Rodrigo Osorio wrote: >> Author: rodrigo >> Date: Thu Feb 7 11:02:46 2019 >> New Revision: 492359 >> URL: https://svnweb.freebsd.org/changeset/ports/492359 >> >> Log: >> Be able to build ufraw without GTK2 option >> >> Add gnome to the uses to make testport happy >> Bump portrevision >> >> PR: 234436 >> Reported by: Thomas Guymer <t.m.guymer@thomasguymer.co.uk> >> >> Modified: >> head/graphics/ufraw/Makefile >> head/graphics/ufraw/pkg-plist >> >> Modified: head/graphics/ufraw/Makefile >> ============================================================================== >> --- head/graphics/ufraw/Makefile Thu Feb 7 10:55:09 2019 (r492358) >> +++ head/graphics/ufraw/Makefile Thu Feb 7 11:02:46 2019 (r492359) >> @@ -3,7 +3,7 @@ >> >> PORTNAME= ufraw >> PORTVERSION= 0.22 >> -PORTREVISION= 8 >> +PORTREVISION= 9 >> CATEGORIES= graphics >> >> MAINTAINER= rodrigo@FreeBSD.org >> @@ -20,7 +20,7 @@ LIB_DEPENDS= libtiff.so:graphics/tiff \ >> >> GNU_CONFIGURE= yes >> CONFIGURE_ARGS= --enable-extras >> -USES= compiler:c++11-lang gettext gmake jpeg pkgconfig autoreconf >> +USES= compiler:c++11-lang gettext gmake jpeg pkgconfig autoreconf gnome >> >> CPPFLAGS+= -I${LOCALBASE}/include >> LDFLAGS+= -lpthread -L${LOCALBASE}/lib >> @@ -58,6 +58,13 @@ GTK2_CONFIGURE_WITH= gtk >> GNOME_USE= GNOME=gconf2 >> GNOME_CONFIGURE_ENABLE= mime >> GNOME_VARS= CATEGORIES+=gnome GCONF_SCHEMAS=${PORTNAME}.schemas >> + >> +.include <bsd.port.options.mk> >> +.if ${PORT_OPTIONS:MGTK2} >> +PLIST_SUB+= NOGTK2="" >> +.else >> +PLIST_SUB+= NOGTK2="@comment " >> +.endif > Naming it NOGTK2 is very confusing. OPTIONS_SUB=yes already adds > something like this just named after the option directly. Why not > just use %%GTK2%% in pkg-plist to achieve the same thing? > Good point !
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ddc6bb0c-dc47-6ad5-3392-5b939b037ae8>