From owner-svn-src-all@freebsd.org Thu Apr 19 11:53:16 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B3C8F9E1AE; Thu, 19 Apr 2018 11:53:16 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2279D813CC; Thu, 19 Apr 2018 11:53:15 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from Allans-MacBook-Pro.local (unknown [12.206.62.130]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 467DD1998F; Thu, 19 Apr 2018 11:53:09 +0000 (UTC) Subject: Re: svn commit: r332559 - head/usr.sbin/mountd To: Rick Macklem , Julian Elischer , Konstantin Belousov , Andriy Gapon Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" References: From: Allan Jude Message-ID: <88c5b5a6-86d4-d786-a874-5e21f6204392@freebsd.org> Date: Thu, 19 Apr 2018 07:53:08 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 11:53:16 -0000 On 2018-04-16 8:02 PM, Rick Macklem wrote: > I wrote: >> Julian Elischer wrote: >>> On 16/4/18 6:56 pm, Konstantin Belousov wrote: >> [stuff snipped] >>>>> + ngroups =3D XU_NGROUPS + 1; >>>> Why XU_NGROUPS and not the value of sysctl("kern.ngroups") ? >>> valid question.. because that is how many are allocated? >>> it was a "minimally invasive patch".. whoever used XU_NGROUPS before >>> should have fixed it. >>> Having said that, thanks for drawing out attention to it.. will >>> probably fix. >> 16 is the limit specified in the RFCs for Sun RPC, so that is the "on the wire" limit. >> I haven't looked at the code. It might make sense to handle more here and then >> set the limit at 16 after getting rid of duplicates, but I have no idea if = >> it matters? >> >> rick > Correcting my own post. Now that I've looked at the code, this doesn't go on > the wire. It does go in the exports structure, which means that this structure > would have to be revised (along with the syscall and VOP calls and the kernel > code that uses it). These credentials are for the "maproot/mapall" export > option and revising the export structure seems like quite a bit of work for this > case. (Until revised XU_NGROUPS is the correct value to set it to, since there > is a "struct xucred" in the exports structure.) > > Since Julian Elischer has been emailing me about adding a "fsid" export option > which allows /etc/exports to set the FSID of the exported fs (which would also > need to go in the exports structure), it might be about time to rev. the exports > structure? > > rick > I second the request for FSID as an export option. It is important for having smooth failover between NFS servers. -- Allan Jude