Date: Fri, 1 Jun 2018 10:37:11 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Ian Lepore <ian@freebsd.org>, "rb@gid.co.uk" <rb@gid.co.uk> Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: RE: PRs are being closed for bogus reasons :-( Message-ID: <20180601173705.77AFD72D@spqr.komquats.com>
next in thread | raw e-mail | index | archive | help
Yes. Let me relay my experience. I received an IPv4 only hack (I hesitate t= o call it a patch). Reworking the submission to fix the immediate issue and= incrementally addresses IPv6 was unsatisfactory to the OP, as his suggeste= d solution would have removed support for IPv6 entirely: his reply was he d= idn't use IPv6. As a committer when sheepherding patches, one must consider the whole, not = someone's immediate beef. I've had many more experiences like this in ports= where one change might satisfy one locale while becoming a POLA violation = for the rest of the community. Unfortunately when the answer is no or let's= try a compromise, feelings get hurt. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert <Cy.Schubert@cschubert.com> or <cy@freebsd.org> The need of the many outweighs the greed of the few. --- -----Original Message----- From: Ian Lepore Sent: 01/06/2018 08:18 To: rb@gid.co.uk Cc: freebsd-hackers@freebsd.org Subject: Re: PRs are being closed for bogus reasons :-( On Fri, 2018-06-01 at 15:53 +0100, rb@gid.co.uk wrote:=0A= > > =0A= > > On 1 Jun 2018, at 15:41, Warner Losh <imp@bsdimp.com> wrote:=0A= > > =0A= > > > =0A= > > > On Fri, Jun 1, 2018 at 8:10 AM, Bob Bishop <rb@gid.co.uk> wrote:=0A= > > > Hi,=0A= > > > =0A= > > > > =0A= > > > > On 31 May 2018, at 22:14, Poul-Henning Kamp <phk@phk.freebsd.dk> wr= ote:=0A= > > > > =0A= > > > > --------=0A= > > > > In message =0A= > > > > , Warner Losh writes:=0A= > > > > =0A= > > > > > =0A= > > > > > There's a problem with the PR database: there's too many bugs.=0A= > > > > And despite the valiant efforts of a number of people over the=0A= > > > > lifetime of the project, it has always had so many bugs that=0A= > > > > everybody just threw their hands in the air and walked away.=0A= > > > > =0A= > > > > The way to improve the situation is to fix PR's, not to complain=0A= > > > > about PRs.=0A= > > > Indeed. But look at the number of PRs with patches that are stuck in = that state. Not pretty.=0A= > > Over the years I've committed dozens of PRs that had patches in them. T= he sad truth is that only about 10-15% of them have comitable patches in th= em when submitted. And that number decays over time as things age in bugzil= la. [etc]=0A= > Sure. But the best a non-comitter can do is to supply a patch tested agai= nst HEAD. If the patch rots because it hasn=A2t been committed six months d= own the line it=A2s not my fault.=0A= > =0A= =0A= The problem isn't bitrot, the problem is that many patches amount to=0A= "here's a hack that works for me," and that isn't necessarily=0A= committable. A committer typically has to do almost as much work to=0A= figure out whether the patch is appropriate for all users on all arches=0A= as they would have to do to develop a fix from scratch. Even if the=0A= submitter has mad skills and submits a perfect patch, better than what=0A= the committer would have done from scratch, the work to analyze=0A= everything and decide whether that's the case still has to be done.=0A= =0A= -- Ian=0A= =0A= _______________________________________________=0A= freebsd-hackers@freebsd.org mailing list=0A= https://lists.freebsd.org/mailman/listinfo/freebsd-hackers=0A= To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"= =0A=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180601173705.77AFD72D>