From owner-svn-src-all@FreeBSD.ORG  Tue Apr 29 12:54:02 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4EB85673;
 Tue, 29 Apr 2014 12:54:02 +0000 (UTC)
Received: from mail.ipfw.ru (mail.ipfw.ru [IPv6:2a01:4f8:120:6141::2])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 103551FE5;
 Tue, 29 Apr 2014 12:54:02 +0000 (UTC)
Received: from [2a02:6b8:0:401:222:4dff:fe50:cd2f] (helo=ptichko.yndx.net)
 by mail.ipfw.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256)
 (Exim 4.76 (FreeBSD)) (envelope-from <melifaro@FreeBSD.org>)
 id 1Wf3eL-000POU-Kz; Tue, 29 Apr 2014 12:44:25 +0400
Message-ID: <535FA0C9.3060308@FreeBSD.org>
Date: Tue, 29 Apr 2014 16:53:29 +0400
From: "Alexander V. Chernikov" <melifaro@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.0.1
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@FreeBSD.org>
Subject: Re: svn commit: r264986 - head/sys/net
References: <201404262103.s3QL3fAX048245@svn.freebsd.org>
 <20140428085941.GW85571@FreeBSD.org>
In-Reply-To: <20140428085941.GW85571@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Apr 2014 12:54:02 -0000

On 28.04.2014 12:59, Gleb Smirnoff wrote:
> On Sat, Apr 26, 2014 at 09:03:41PM +0000, Alexander V. Chernikov wrote:
> A> @@ -1425,6 +1431,95 @@ bad:
> A>  #undef ifpaddr
> A>  #undef flags
> A>
> A> +#define	senderr(e) { error = e; goto bad; }
>
> ...
>
> A> +		if (error != 0)
> A> +			senderr(error);
>
> This resolves to "error = error". Surprised that compiler is silent.
>
> Can this line and others like it be replaced with?
Yup. done in r265091.
> 	if (error)
> 		goto bad;
>