From owner-svn-src-all@freebsd.org Wed Mar 7 23:18:58 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B6DBF3BA1C; Wed, 7 Mar 2018 23:18:58 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 10DA4754B5; Wed, 7 Mar 2018 23:18:56 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w27NIrk4056502; Wed, 7 Mar 2018 15:18:53 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w27NIrI6056501; Wed, 7 Mar 2018 15:18:53 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201803072318.w27NIrI6056501@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r330451 - in stable/11/sys: dev/iwm dev/otus dev/usb/wlan net80211 In-Reply-To: To: Eitan Adler Date: Wed, 7 Mar 2018 15:18:53 -0800 (PST) CC: John Baldwin , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 23:18:58 -0000 > On 7 March 2018 at 09:37, John Baldwin wrote: > > On Tuesday, March 06, 2018 06:46:37 PM Eitan Adler wrote: > >> On 6 March 2018 at 08:26, John Baldwin wrote: > >> > On Monday, March 05, 2018 07:13:59 PM Eitan Adler wrote: > >> >> On 5 March 2018 at 10:08, John Baldwin wrote: > >> >> > On Monday, March 05, 2018 07:54:58 AM Eitan Adler wrote: > >> >> >> Author: eadler > >> >> >> Date: Mon Mar 5 07:54:57 2018 > >> >> >> New Revision: 330451 > >> >> >> URL: https://svnweb.freebsd.org/changeset/base/330451 > >> >> >> > >> >> >> Log: > >> >> >> MFC r306837: > >> >> >> > >> >> >> [net80211] extend the ieee80211_rx_stats struct to include more information. > >> >> > > >> >> > Have you thought about the KBI implications of this change and some of the > >> >> > other changes you've merged? > >> >> > >> >> I do have a copy of the modules from 11.1 and have loaded them at > >> >> various points in time after merging. That said, I am not perfect. > >> >> Unfortunately, my -STABLE box did not have fully functioning drivers > >> >> before these changes so its difficult to test anything beyond "loads > >> >> and does not panic.". I havn't done so today yet, but that will happen > >> >> soon. > >> >> > >> >> Ensuring these things work through code inspection is certainly > >> >> possible and I've skipped over several changes as a result. > >> > > >> > Loading a module doesn't alone doesn't actually test for breakage. > >> > >> I'm aware. In this case I should likely just revert this change since > >> its a pretty blatant break. > > > > I suspect many of these changes for iwm, etc. are all intertwined so I'm not > > sure if you can leave out individual ones. > > Possibly. I do have iwm working on my laptop though. I also know of > one open PR assigned to me w.r.t. a model I don't own. I'll be > addressing it some time this week. I believe I also have a tester of stable/11 iwm patches avaliable, he has an 8265? -- Rod Grimes rgrimes@freebsd.org