From owner-cvs-all@FreeBSD.ORG  Thu Dec  1 19:38:26 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0AB3516A41F;
	Thu,  1 Dec 2005 19:38:26 +0000 (GMT) (envelope-from gad@FreeBSD.org)
Received: from smtp4.server.rpi.edu (smtp4.server.rpi.edu [128.113.2.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BC58A43D8A;
	Thu,  1 Dec 2005 19:38:16 +0000 (GMT) (envelope-from gad@FreeBSD.org)
Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47])
	by smtp4.server.rpi.edu (8.13.0/8.13.0) with ESMTP id jB1JcBws007572;
	Thu, 1 Dec 2005 14:38:13 -0500
Mime-Version: 1.0
Message-Id: <p06230900bfb4fa9993bf@[128.113.24.47]>
In-Reply-To: <20051201172757.GG20961@ip.net.ua>
References: <200512011708.jB1H8u3Y065515@repoman.freebsd.org>
	<20051201172757.GG20961@ip.net.ua>
Date: Thu, 1 Dec 2005 14:38:11 -0500
To: Ruslan Ermilov <ru@FreeBSD.org>, Warner Losh <imp@FreeBSD.org>
From: Garance A Drosehn <gad@FreeBSD.org>
Content-Type: text/plain; charset="us-ascii" ; format="flowed"
X-CanItPRO-Stream: default
X-RPI-SA-Score: undef - spam-scanning disabled
X-Scanned-By: CanIt (www . canit . ca) on 128.113.2.4
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src Makefile.inc1
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Dec 2005 19:38:26 -0000

At 7:27 PM +0200 12/1/05, Ruslan Ermilov wrote:
>On Thu, Dec 01, 2005 at 05:08:56PM +0000, Warner Losh wrote:
>>  imp         2005-12-01 17:08:56 UTC
>>
>>    FreeBSD src repository
>>
>>    Modified files:
>>      .                    Makefile.inc1
>>    Log:
>  >   In make buildenv, spell sh as ${SHELL}.  In this case, we don't
>  >   want to hard code /bin/sh since we're forking it for the user
>  >   to type commands into.  As such, ${SHELL} is the preferred
>  >   thing users type commands into.
>
>Please consider backing it out.  In this case, we want to hard code
>it to "sh" since the stock ~root/.cshrc always resets $PATH, which
>breaks "make buildenv" for root (which most of us use).
>   Testcase: "which cc" from under "make buildenv" shell.

Hmm.  How about:

BUILDENVSHELL?=sh
buildenv:
	@echo Entering world for ${TARGET_ARCH}:${TARGET}
	@cd ${.CURDIR} && env ${WMAKEENV} ${BUILDENVSHELL} || true

-- 
Garance Alistair Drosehn     =      gad@gilead.netel.rpi.edu
Senior Systems Programmer               or   gad@FreeBSD.org
Rensselaer Polytechnic Institute;             Troy, NY;  USA